[AMQ-3846] The JMX message move, copy and remove operation do not take messages in FIFO order

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.5.1, 5.6.0
• Fix Version/s: 5.7.0
• Component/s: JMX
• Assignee: Timothy A. Bish
• Reporter: David Harp
• Created: 16/May/12 16:07
• Updated: 26/Jun/12 22:21
• Resolved: 26/Jun/12 22:21

Description

When a page is pulled in, it is placed in a LinkedHashMap which preserves the queue order, but the below code then pulls the values from the LinkedHashMap and puts them in a Set. This causes the FIFO order of the queue to be lost. If the number of max messages to move is smaller the the page size, then the outcome looks like random messages from the queue being moved (copied or removed).

...

Set<MessageReference> set = new HashSet<MessageReference>();
ConnectionContext context = createConnectionContext();
do {
doPageIn(true);
pagedInMessagesLock.readLock().lock();
try

{ set.addAll(pagedInMessages.values()); }

finally

{ pagedInMessagesLock.readLock().unlock(); }

...

Can this be changed to preserve the queue order?