ActiveMQ
  1. ActiveMQ
  2. AMQ-3630

NetworkBridgeFilterFactory should be assigned to Queue not NetworkBridge

    Details

      Description

      We can assign NetworkBridgeFilterFactory such as DefaultNetworkBridgeFilterFactory or conditionalNetworkBridgeFilterFactory for queue.But the source code on the trunk,class DemandForwardingBridgeSupport in fact, assigns NetworkBridgeFilterFactory to NetworkBridge,this causes DefaultNetworkBridgeFilterFactory will be applied at first even though specifying conditionalNetworkBridgeFilterFactory for the queue.The solution is making property filterFactory of DemandForwardingBridgeSupport to be a local variable in the method createNetworkBridgeFilter.

        Activity

        Hide
        Gary Tully added a comment -

        The observation is correct, the filter should be evaluated per destination.
        fix in http://svn.apache.org/viewvc?rev=1325735&view=rev

        Show
        Gary Tully added a comment - The observation is correct, the filter should be evaluated per destination. fix in http://svn.apache.org/viewvc?rev=1325735&view=rev
        Hide
        Rob Davies added a comment -

        Not seeing this in the code - a patch would help . Moving this to 5.6.1 in hope of a patch

        Show
        Rob Davies added a comment - Not seeing this in the code - a patch would help . Moving this to 5.6.1 in hope of a patch
        Hide
        Timothy Bish added a comment -

        Do you have a test case for this? Care to submit a test and a patch for it?

        Show
        Timothy Bish added a comment - Do you have a test case for this? Care to submit a test and a patch for it?

          People

          • Assignee:
            Gary Tully
            Reporter:
            SuoNayi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development