ActiveMQ
  1. ActiveMQ
  2. AMQ-2775

Race condition in org.apache.activemq.util.osgi.Activator

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Later
    • Affects Version/s: 5.3.2
    • Fix Version/s: 5.10.0
    • Component/s: OSGi/Karaf
    • Labels:
      None

      Description

      There's a race condition between start and create methods of Activator. If a bundle that was started before activemq-core does something that causes a call to Activator.create, and Activator.start is still scanning bundles for contributed service files, an IOException results.

      In practice, this occurred after upgrading from 5.3.0 to 5.3.2 because another bundle at the same start level as activemq-core programmatically instantiated a broker from a different thread. The activemq-core activator was still scanning the installed bundles and hadn't gotten to itself yet, so the result was a failure to instantiate the tcp handler.

      Making start/create/stop synchronized would fix this issue.

        Activity

        Michael Pilquist created issue -
        Rob Davies made changes -
        Field Original Value New Value
        Fix Version/s 5.4.1 [ 12332 ]
        Bruce Snyder made changes -
        Fix Version/s 5.4.1 [ 12332 ]
        Fix Version/s 5.5.0 [ 12344 ]
        Jeff Turner made changes -
        Project Import Fri Nov 26 22:32:02 EST 2010 [ 1290828722158 ]
        Dejan Bosanac made changes -
        Fix Version/s 5.5.0 [ 12315626 ]
        Fix Version/s 5.4.2 [ 12315625 ]
        Gary Tully made changes -
        Fix Version/s 5.6.0 [ 12316331 ]
        Fix Version/s 5.5.0 [ 12315626 ]
        Claus Ibsen made changes -
        Assignee Claus Ibsen [ davsclaus ]
        Claus Ibsen made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Fix Version/s 5.10.0 [ 12324950 ]
        Fix Version/s 5.x [ 12316331 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Component/s OSGi/Karaf [ 12321013 ]
        Claus Ibsen made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Later [ 7 ]

          People

          • Assignee:
            Claus Ibsen
            Reporter:
            Michael Pilquist
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development