[AMQ-2542] Tidy up store duplicate suppression from failover recovery - consistent store implementation with help from transportConnection

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3.0
• Fix Version/s: 5.4.0
• Component/s: Broker
• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 21/Dec/09 11:27
• Updated: 27/Nov/10 04:25
• Resolved: 08/Jul/10 14:39

Description

With failover - with a failure before a reply is received to a send or a transaction commit, the send or transaction will be replayed and will be a duplicate.
The transportConnector should know that recovery/reconnection has happened and should enforce duplicate suppression based on obtaining the last producer sequence number from the store.
Currently, duplicate suppression happens at the jdbc message store add, amq store reference store etc... it is not consistent and it is abased on a suitable audit window which may be non deterministic. Would be best to be fully deterministic and consistent (as in a single persistence adapter api)

To make this perform, a transportConnection needs to be flagged as a reconnect which can precipitate the duplicate suppression, possibly needing a wireformat update. This flag would also help with unmatched acks after failover but maybe that flag can be in an ack...

This is relevant both when the broker is restarted or when a connection is dropped.

related issue with relevant test : https://issues.apache.org/activemq/browse/AMQ-2540

Issue Links

• is depended upon by: AMQCPP-284 Generate Openwire 6 commands and marshalers to keep pace with the AMQ 5.4 broker.