[AMQ-1955] MessageServlet reads too many messages

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0.0, 5.1.0, 5.2.0, 5.3.0
• Fix Version/s: 5.2.0
• Component/s: Transport

Environment

Any

• Patch Info: Patch Available
• Assignee: Dejan Bosanac
• Reporter: Mike Richmond
• Created: 26/Sep/08 14:46
• Updated: 06/Nov/08 10:47
• Resolved: 09/Oct/08 13:18

Description

MessageServlet inside activemq-web will pull maxMessages+1 messages off of the queue but only write a response containing maxMessages.

After some debugging, I figured out that the problem is with the while loop that reads messages inside the doMessages method (and doMessagesWithoutContinuation). It always reads a message at the end of the loop, without first checking to see if maxMessages has already been reached.

Attached is a patch that corrects this issue.