[AMQ-1805] Persistent message leak when broker run out of disk space

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1.0
• Fix Version/s: 5.2.0
• Component/s: Broker

Environment

ActiveMQ 5.1 (AMQStore w/o SystemUsage configuration)
Windows XP SP2
ActiveMQ CPP 2.1.3

• Patch Info: Patch Available
• Assignee: Robert Davies
• Reporter: Bruce Lee
• Created: 17/Jun/08 15:50
• Updated: 19/Jun/08 16:11
• Resolved: 19/Jun/08 16:00

Description

In our environment, we have several ActvieMQ CPP clients sending persistent messages continuously to a ActiveMQ 5.1 broker. In normal condition the broker works fine until it ran out of disk space. At that point the client would receive out of disk space advisory message AFTER sending the message, therefore the message should be removed from broker, however, the message are kept in the memory due to a problem in the DataFileAppender & AsyncDatamanager, when the disk is full, the message is saved in the inflightWrites map but never taken out since the enqueue will fail due to IOException.

synchronized (this) {
// Find the position where this item will land at.
DataFile dataFile = dataManager.allocateLocation(location);
if( !sync )

{ inflightWrites.put(new WriteKey(location), write); }

batch = enqueue(dataFile, write);
}

and

synchronized (this)

{ // Find the position where this item will land at. DataFile dataFile = dataManager.allocateLocation(location); inflightWrites.put(new WriteKey(location), write); batch = enqueue(dataFile, write); }

Issue Links

• depends upon: AMQ-724 Stomp client is not removed from the broker on client disconnect