[AMBARI-4782] Error in getting host components with state INSTALL_FAILED

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 2.1.0
• Component/s: ambari-server, test
• Assignee: Vitaly Brodetskyi
• Reporter: Dmitry Lysnichenko
• Created: 21/Feb/14 15:12
• Updated: 10/Apr/15 12:00
• Resolved: 10/Apr/15 10:23

Description

The problem

When try to get query on api/v1/clusters/<clustername>/host_components?HostRoles/state=INSTALL_FAILED

Response is

{ "status" : 400, "message" : "Invalid Request: Invalid arguments, invalid desired state, desiredState=INSTALL_FAILED" }

This issue is rooted at the over all issue Ambari has where when "state" is specified in the API requests it is always interpreted as "desired_state". And INSTALL_FAILED is an invalid "desired_state". Just fixing the GET calls to interpret request:state as "state" (current state of a host component) might be the right thing to do but will make the get calls to behave differently than other calls. For example, request to set all component which are in INSTALL_FAILED state to INIT (or MAINTENANCE) will not work as expected.

The proposal:

The fix is to distinguish between "current_state" and "desired_state" and promote "current_state" as a first class query parameter. "state" query parameter will be still mapped to "desired_state" to maintain backward compatibility.

Issue Links

• links to: review request