[AMBARI-25874] Fix AlertTargetResourceProviderTest to work after merging AMBARI-25300

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0
• Component/s: ambari-server
• Assignee: Kengo Seki
• Reporter: Kengo Seki
• Created: 27/Feb/23 15:39
• Updated: 28/Feb/23 06:52
• Resolved: 28/Feb/23 06:52

Description

Currently, running the following test fails:

$ mvn clean test -Dtest="AlertTargetResourceProviderTest#testEnable" -f ambari-server/pom.xml

...

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.ambari.server.controller.internal.AlertTargetResourceProviderTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.173 s <<< FAILURE! - in org.apache.ambari.server.controller.internal.AlertTargetResourceProviderTest
[ERROR] testEnable(org.apache.ambari.server.controller.internal.AlertTargetResourceProviderTest)  Time elapsed: 3.112 s  <<< FAILURE!
java.lang.AssertionError: 

  Unexpected method call AlertDispatchDAO.findTargetByName("The Administrators"):
    AlertDispatchDAO.create(capture(Nothing captured yet)): expected: 1, actual: 0
	at org.apache.ambari.server.controller.internal.AlertTargetResourceProviderTest.testEnable(AlertTargetResourceProviderTest.java:1095)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   AlertTargetResourceProviderTest.testEnable:1095 
  Unexpected method call AlertDispatchDAO.findTargetByName("The Administrators"):
    AlertDispatchDAO.create(capture(Nothing captured yet)): expected: 1, actual: 0
[INFO] 
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:04 min
[INFO] Finished at: 2023-02-28T00:18:38+09:00
[INFO] ------------------------------------------------------------------------

This is because AMBARI-25300 changed AlertTargetResourceProvider#createAlertTargets to always (except for the cases of exception) call AlertDispatchDAO#findTargetByName
(https://github.com/apache/ambari/commit/05c826ec1a0eb2d672ad84505d9bde95a578fa09#diff-fff060a3bbe1aa6b1fd811d058ba8005333f8422dc6b4de92e133c4e2988f000), but the corresponding mock in AlertTargetResourceProviderTest#testEnable doesn't have a defined behavior for that method.

Issue Links

• links to: GitHub PR#3651