[AMBARI-23336] Editing configurations usings configs.py doesnt have options to pass service config version note

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.1
• Fix Version/s: 3.0.0
• Component/s: ambari-server
• Labels: pull-request-available

Environment

Ambari -2.6.1

• Assignee: Akhil Naik
• Reporter: Akhil Naik
• Created: 23/Mar/18 09:33
• Updated: 03/Dec/18 09:03
• Resolved: 03/Dec/18 09:03

Description

Editing configurations usings configs.py doesnt have options to pass service config version note

But we can pass service config version note via curl command and in ambari-ui

This feature should be implemented for actions 'SET' and 'DELETE'

Suggested give '-b' as option to give service config version note

ex :

/var/lib/ambari-server/resources/scripts/configs.py -u admin -p admin -t 8080 -n asnaik -l localhost -a set -c capacity-scheduler -k "yarn.scheduler.capacity.resource-calculator" -v "org.apache.hadoop.yarn.util.resource.DefaultResourceCalculator" -b "Creating a new version with CPU scheduling off"

and the Help of the configs.py should be
Please edit the help page : https://cwiki.apache.org/confluence/display/AMBARI/Modify+configurations#Modifyconfigurations-Editconfigurationusingconfigs.py

[root@pwd1 scripts]#  /var/lib/ambari-server/resources/scripts/configs.py --help
Usage: configs.py [options]

Options:
  -h, --help            show this help message and exit
  -t PORT, --port=PORT  Optional port number for Ambari server. Default is
                        '8080'. Provide empty string to not use port.
  -s PROTOCOL, --protocol=PROTOCOL
                        Optional support of SSL. Default protocol is 'http'
  -a ACTION, --action=ACTION
                        Script action: <get>, <set>, <delete>
  -l HOST, --host=HOST  Server external host name
  -n CLUSTER, --cluster=CLUSTER
                        Name given to cluster. Ex: 'c1'
  -c CONFIG_TYPE, --config-type=CONFIG_TYPE
                        One of the various configuration types in Ambari. Ex:
                        core-site, hdfs-site, mapred-queue-acls, etc.
  -b VERSION_NOTE, --version-note=VERSION_NOTE
                        Version change notes which will help to know what has
                        been changed in this config , this value is optional
                        and is used for action set

  To specify credentials please use "-e" OR "-u" and "-p'":
    -u USER, --user=USER
                        Optional user ID to use for authentication. Default is
                        'admin'
    -p PASSWORD, --password=PASSWORD
                        Optional password to use for authentication. Default
                        is 'admin'
    -e CREDENTIALS_FILE, --credentials-file=CREDENTIALS_FILE
                        Optional file with user credentials separated by new
                        line.

  To specify property(s) please use "-f" OR "-k" and "-v'":
    -f FILE, --file=FILE
                        File where entire configurations are saved to, or read
                        from. Supported extensions (.xml, .json>)
    -k KEY, --key=KEY   Key that has to be set or deleted. Not necessary for
                        'get' action.
    -v VALUE, --value=VALUE
                        Optional value to be set. Not necessary for 'get' or
                        'delete' actions.

Issue Links

• links to: GitHub Pull Request #762