[AMBARI-23158] Fix NPE in Host Components query.

• Type: Bug
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Fix Version/s: 3.0.0
• Component/s: ambari-server
• Labels: pull-request-available
• Assignee: Swapan Shridhar
• Reporter: Swapan Shridhar
• Due: 06/Mar/18
• Created: 06/Mar/18 20:48
• Updated: 06/Mar/18 22:44

Description

serviceComponentHostRequest may not get instantiated if HOST_COMPONENT_HOST_COMPONENT_ID_PROPERTY_ID is null.

/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java

  private ServiceComponentHostRequest getRequest(Map<String, Object> properties) {
    ServiceComponentHostRequest serviceComponentHostRequest = null;
    if (properties.get(HOST_COMPONENT_HOST_COMPONENT_ID_PROPERTY_ID) != null) {
      Long hostComponentId = properties.get(HOST_COMPONENT_HOST_COMPONENT_ID_PROPERTY_ID) instanceof String ?
              Long.parseLong((String) properties.get(HOST_COMPONENT_HOST_COMPONENT_ID_PROPERTY_ID)) :
              (Long) properties.get(HOST_COMPONENT_HOST_COMPONENT_ID_PROPERTY_ID);

      serviceComponentHostRequest = new ServiceComponentHostRequest(
              (String) properties.get(HOST_COMPONENT_CLUSTER_NAME_PROPERTY_ID),
              (String) properties.get(HOST_COMPONENT_SERVICE_GROUP_NAME_PROPERTY_ID),
              (String) properties.get(HOST_COMPONENT_SERVICE_NAME_PROPERTY_ID),
              hostComponentId,
              (String) properties.get(HOST_COMPONENT_COMPONENT_NAME_PROPERTY_ID),
              (String) properties.get(HOST_COMPONENT_COMPONENT_TYPE_PROPERTY_ID),
              (String) properties.get(HOST_COMPONENT_HOST_NAME_PROPERTY_ID),
              (String) properties.get(HOST_COMPONENT_DESIRED_STATE_PROPERTY_ID));
    }

Issue Links

• links to: GitHub Pull Request #566