[AMBARI-23021] ServiceInfo: credential_store_supported attempts to overwrite maintenance_state

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.7.0
• Component/s: ambari-server
• Labels: pull-request-available
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 19/Feb/18 13:55
• Updated: 14/Mar/18 16:01
• Resolved: 14/Mar/18 16:01

Description

Try to update credential_store_supported property of a service:

$ curl -X PUT -d @- "http://$AMBARI_SERVER:8080/api/v1/clusters/TEST/services/HDFS" <<EOF
{ "ServiceInfo": { "credential_store_supported": "true" } }
EOF
HTTP/1.1 400 Bad Request
...
  "message" : "java.lang.IllegalArgumentException: No enum constant org.apache.ambari.server.state.MaintenanceState.true"

Expected response:

IllegalArgumentException: Invalid arguments, cannot update credential_store_supported as it is set only via service definition.

The response code is the same as expected due to a coincidence.

The problem is setting the wrong property:

 414     o = properties.get(SERVICE_CREDENTIAL_STORE_SUPPORTED_PROPERTY_ID);
 415     if (null != o) {
 416       svcRequest.setMaintenanceState(o.toString());
 417     }

Issue Links

• links to: GitHub Pull Request #599