[AMBARI-22604] Fix hostConfigMappingEntity cluster_id, concurrency in ClusterImpl and serviceConfigTypes initialization

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: ambari-server
• Fix Version/s: 3.0.0
• Component/s: ambari-server
• Assignee: Dmytro Sen
• Reporter: Dmytro Sen
• Created: 06/Dec/17 14:18
• Updated: 08/Dec/17 12:42
• Resolved: 08/Dec/17 12:42

Description

1) HostConfigMappingEntity is not correct. You can't use same field cluster_id for current entity and for joined columns. Use ClusterTest.testDesiredConfig() to see this issue.

2) As you can see in ClusterImpl we are using concurrent maps/lists and locks in methods. Please do the same for your code chnages.

3) Initialize map serviceConfigTypes, it will prevent many NPE and additional check for NULL.

Issue Links

• links to: Review board