[AMBARI-22498] Remove trailing lines (if any) from llapstatus command before converting the o/p to JSON.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.6.1
• Component/s: ambari-server
• Assignee: Swapan Shridhar
• Reporter: Swapan Shridhar
• Due: 23/Nov/17
• Created: 22/Nov/17 08:20
• Updated: 22/Nov/17 19:46
• Resolved: 22/Nov/17 18:28

Description

Existing code was removing extra lines from the beginning which may come because of MOTD.
Similar issue can happen if there are extra lines as the end, which if passed in for converting to JSON will fail.

EXAMPLE of extra lines at beginning and end sandwiching the JSOn structure which needs to be parsed

######## Hortonworks #############
This is MOTD message, added for testing in qe infra
{
  "amInfo" : {
    "appName" : "llap",
    "appType" : "org-apache-slider",
    "appId" : "application_1455662455106_10882",
    "containerId" : "container_e14_1455662455106_10882_01_000001",
    "hostname" : "HOST_REPLACED",
    "amWebUrl" : "http://HOST_REPLACED:1025/"
  },
  "state" : "RUNNING_ALL",
  "originalConfigurationPath" : "hdfs://HOST_REPLACED:8020/user/USER_REPLACED/.slider/cluster/llap/snapshot",
  "generatedConfigurationPath" : "hdfs://HOST_REPLACED:8020/user/USER_REPLACED/.slider/cluster/llap/generated",
  "desiredInstances" : 3,
  "liveInstances" : 3,
  "appStartTime" : 1459625802169,
  "llapInstances" : [ {
    "hostname" : "HOST_REPLACED",
    "containerId" : "container_e14_1455662455106_10882_01_000003",
    "statusUrl" : "http://HOST_REPLACED:15002/status",
    "webUrl" : "http://HOST_REPLACED:15002",
    "rpcPort" : 15001,
    "mgmtPort" : 15004,
    "shufflePort" : 15551
  }, {
    "hostname" : "HOST_REPLACED",
    "containerId" : "container_e14_1455662455106_10882_01_000002",
    "statusUrl" : "http://HOST_REPLACED:15002/status",
    "webUrl" : "http://HOST_REPLACED:15002",
    "rpcPort" : 15001,
    "mgmtPort" : 15004,
    "shufflePort" : 15551
  }, {
    "hostname" : "HOST_REPLACED",
    "containerId" : "container_e14_1455662455106_10882_01_000004",
    "statusUrl" : "http://HOST_REPLACED:15002/status",
    "webUrl" : "http://HOST_REPLACED:15002",
    "rpcPort" : 15001,
    "mgmtPort" : 15004,
    "shufflePort" : 15551
  } ]
}

# THIS IS A DUMMY TRAILING MESSAGE 1
# THIS IS A DUMMY TRAILING MESSAGE 2

Fix: Added code to remove the trailing lines as well.

Issue Links

• links to: Reviewboard