[AMBARI-22110] Some ResourceProviders Are Not Transactional

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Component/s: ambari-server
• Assignee: Nate Cole
• Reporter: Nate Cole
• Created: 02/Oct/17 14:44
• Updated: 02/Oct/17 22:20
• Resolved: 02/Oct/17 20:43

Description

While investigating an issue with VDFs which don't contain any OS's which match the cluster, it was observed that, even after throwing an Exception inside of a Transaction, the entities created inside that transaction were being committed.

Eventual investigation led to a problem between Guice/AOP and our ResourceProviders. The Guice documentations says that @Transactional methods can only be intercepted on objects created by Guice:

https://github.com/google/guice/wiki/AOP:

Instances must be created by Guice by an @Inject-annotated or no-argument constructor It is not possible to use method interception on instances that aren't constructed by Guice.

However, some of the ResourceProviders which use @Transactional are not constructed by Guice.

Issue Links

• links to: Review Board