[AMBARI-21744] package_regex in get_package_from_available() can match wrong pkg

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.5.2
• Fix Version/s: 2.6.0
• Component/s: ambari-server
• Assignee: Dmitry Lysnichenko
• Reporter: Dmitry Lysnichenko
• Created: 17/Aug/17 14:32
• Updated: 30/Aug/17 11:42
• Resolved: 30/Aug/17 11:02

Description

Due to the issue with regex (missing ^ and $ boundaries), resource_management.libraries.script.script.Script#get_package_from_available may return wrong package.

>>> list=['hbase_3_0_0_0_229-master', 'hbase_3_0_0_0_229']
>>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229-master'):
...    print 'YES'
...
YES
>>> if re.match('hbase_(\d|_)+', 'hbase_3_0_0_0_229'):
...    print 'YES'
...
YES

In this case, the first package name from a list of available packages will be returned.
The impact of bug is that we may install a wrong package if it's simillary named and goes first at list. Patch is a single-line fix.

Issue Links

• links to: review_request_