Uploaded image for project: 'Ambari'
  1. Ambari
  2. AMBARI-19540

Possibly too frequent calls to stack advisor as user changes sliders

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.5.0
    • 2.5.0
    • ambari-web
    • None

    Description

      As you can see 3 calls are made while changing from 1024 to 2048 and similarly 3 calls when coming back to 1024.
      Beyond performance concern, multiple calls have a functional issue. The call includes previous value of the changed property - see the values. I would have expected the old value to be the value that was the original/saved value. However, it is wherever UI makes the stack advisor calls.
      [root@smq1-1 stack-recommendations]# find . -name services.json | xargs grep -A 3 changed
      ./55/services.json: "changed-configurations" : [ {
      ./55/services.json- "type" : "yarn-site",
      ./55/services.json- "name" : "yarn.scheduler.minimum-allocation-mb",
      ./55/services.json- "old_value" : "1024"

      ./56/services.json: "changed-configurations" : [ {
      ./56/services.json- "type" : "yarn-site",
      ./56/services.json- "name" : "yarn.scheduler.minimum-allocation-mb",
      ./56/services.json- "old_value" : "1280"

      ./57/services.json: "changed-configurations" : [ {
      ./57/services.json- "type" : "yarn-site",
      ./57/services.json- "name" : "yarn.scheduler.minimum-allocation-mb",
      ./57/services.json- "old_value" : "1792"

      ./58/services.json: "changed-configurations" : [ {
      ./58/services.json- "type" : "yarn-site",
      ./58/services.json- "name" : "yarn.scheduler.minimum-allocation-mb",
      ./58/services.json- "old_value" : "2048"

      ./59/services.json: "changed-configurations" : [ {
      ./59/services.json- "type" : "yarn-site",
      ./59/services.json- "name" : "yarn.scheduler.minimum-allocation-mb",
      ./59/services.json- "old_value" : "1792"

      ./60/services.json: "changed-configurations" : [ {
      ./60/services.json- "type" : "yarn-site",
      ./60/services.json- "name" : "yarn.scheduler.minimum-allocation-mb",
      ./60/services.json- "old_value" : "1280"

      Attachments

        1. AMBARI-19540.patch
          2 kB
          Antonenko Alexander
        2. AMBARI-19540.v0.patch
          0.8 kB
          Vivek Ratnavel Subramanian
        3. AMBARI-19540.v1.branch-2.5.patch
          0.8 kB
          Vivek Ratnavel Subramanian

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            aantonenko Antonenko Alexander
            vivekratnavel Vivek Ratnavel Subramanian
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment