[AMBARI-19149] Clean up Ambari Server source code warnings

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Component/s: ambari-server
• Epic Link: Code cleanup
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 09/Dec/16 12:28
• Updated: 04/Oct/19 16:12
• Resolved: 12/Jun/17 11:19

Description

Eclipse's default warnings generated for ambari-server number roughly over 3300. Out of these, at least half of them are:

• Unused imports
• Type safety due to forgotten <>
• Missing Serialization IDs from anonymous HashMap implementations
• Unused variables
• Capture<T> in tests
• switch fall-through and missing case statements: only makes changes which won't affect existing functionality

This makes spotting actual problems, like missing case statements a nightmare. We need to go through and clean out as many of these warnings as possible.

Note: With respect to the import cleanup, the IDE of choice should have the following import order setup. They should always be expanded and never use *.

1. java
2. javax
3. org
4. com
5. other

Issue Links

• links to: Review request #2: fallthrough
• links to: Review request #3: empty blocks
• links to: Review request #4: compiler warnings
• links to: Review request #5: unchecked casts in {{*AuditEventBuilder}}
• links to: Review request #6: check test source, too
• links to: Review request #7: redundant type arguments
• links to: Review request #8: StringBuffer
• links to: Review request #9: String concatenation in StringBuilder.append()
• links to: Review request #10: redundant modifiers
• links to: Review request #11: unresolved references in javadoc
• links to: Review request #12: dangling Javadoc comments
• links to: Review request #13: identical catch blocks
• links to: Review request #14: debug log