[AMBARI-18350] Declare URL uniqueness in repoinfo.xml

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: trunk
• Component/s: ambari-server
• Assignee: Dmitry Lysnichenko
• Reporter: Dmitry Lysnichenko
• Created: 09/Sep/16 17:02
• Updated: 14/Sep/16 12:15
• Resolved: 14/Sep/16 10:23

Description

Repository info for a stack can contain any number of repo definitions. For HDP, there are two repos used (HDP and HDP-UTILS). When checking repositories for duplicate URL, the code does this:

if (! repositoryEntity.getRepositoryId().startsWith("HDP-UTILS") &&  // HDP-UTILS is shared between repo versions
! existingRepoVersion.getId().equals(repositoryVersion.getId())) { // Allow modifying already defined repo version
existingRepoUrls.add(repositoryEntity.getBaseUrl());
}

We should make the unique declaration directly for the repository so authors don't have to guess. This entails:

• Change repoinfo.xml to support a <unique> element within <repo>
• <unique> should apply to, say, versions of HDP that change with each release. Absence of said element implies false for backward compatibility.
• Change RepositoryVersionResourceProvider.validateRepositoryVersion(...) to use this boolean for uniqueness check.
• Update the version_definition.xsd to include this new element.

Issue Links

• links to: review_request_