Uploaded image for project: 'Ambari'
  1. Ambari
  2. AMBARI-17898

Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: trunk
    • Component/s: ambari-metrics
    • Labels:
      None

      Description

      This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to authenticate".
      In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But Ambari Metrics Monitor, a client of Ambari Metrics Collector, currently does not support Kerberos HTTP SPNEGO authentication.

      /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
      2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: http://metrics-collector:6188/ws/v1/timeline/metrics
      2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to server. HTTP Error 401: Authentication required
      2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...

      1. AMBARI-17898_trunk_june.patch
        24 kB
        Qin Liu
      2. AMBARI-17898-trunk_2.patch
        24 kB
        Dmytro Sen

        Issue Links

          Activity

          Hide
          eyang Eric Yang added a comment -

          It appears to be a race condition in the unit test. test_wait_for_process_death worked fine in later commits. Ambari Agent code unit test failure seems to have no relationship with this patch. Hence, I close this as resolved. Thank you Qin Liu for looking into this.

          Show
          eyang Eric Yang added a comment - It appears to be a race condition in the unit test. test_wait_for_process_death worked fine in later commits. Ambari Agent code unit test failure seems to have no relationship with this patch. Hence, I close this as resolved. Thank you Qin Liu for looking into this.
          Hide
          qinliu Qin Liu added a comment -

          Hi Eric,
          Hmmm, The patch passed all the unit test on July 5. Let me check.

          Show
          qinliu Qin Liu added a comment - Hi Eric, Hmmm, The patch passed all the unit test on July 5. Let me check.
          Hide
          qinliu Qin Liu added a comment -

          Hi Eric, Thank you so much!

          Show
          qinliu Qin Liu added a comment - Hi Eric, Thank you so much!
          Hide
          eyang Eric Yang added a comment -

          Qin Liu Ambari Agent seems to have trouble shutdown after applying this patch, and you check?

          ======================================================================
          FAIL: test_wait_for_process_death (TestProcessUtils.TestProcessUtils)
          ----------------------------------------------------------------------
          Traceback (most recent call last):
            File "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
              return func(*args, **keywargs)
            File "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py", line 202, in test_wait_for_process_death
          
          Show
          eyang Eric Yang added a comment - Qin Liu Ambari Agent seems to have trouble shutdown after applying this patch, and you check? ====================================================================== FAIL: test_wait_for_process_death (TestProcessUtils.TestProcessUtils) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-common/src/test/python/mock/mock.py" , line 1199, in patched return func(*args, **keywargs) File "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py" , line 202, in test_wait_for_process_death
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #7918 (See https://builds.apache.org/job/Ambari-trunk-Commit/7918/)
          AMBARI-17898. Add Kerberos HTTP SPNEGO authentication support to Ambari (eyang: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=d260c89263ee0471514b4cfb8ce938134eceea12)

          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
          • (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
          • (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #7918 (See https://builds.apache.org/job/Ambari-trunk-Commit/7918/ ) AMBARI-17898 . Add Kerberos HTTP SPNEGO authentication support to Ambari (eyang: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=d260c89263ee0471514b4cfb8ce938134eceea12 ) (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
          Hide
          eyang Eric Yang added a comment -

          I just committed this, thanks Qin Liu.

          Show
          eyang Eric Yang added a comment - I just committed this, thanks Qin Liu.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12874128/AMBARI-17898_trunk_june.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 core tests. The patch passed unit tests in ambari-server.

          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11712//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12874128/AMBARI-17898_trunk_june.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 core tests . The patch passed unit tests in ambari-server. Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11712//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12874128/AMBARI-17898_trunk_june.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 core tests. The patch passed unit tests in ambari-server.

          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11675//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12874128/AMBARI-17898_trunk_june.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 core tests . The patch passed unit tests in ambari-server. Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11675//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12849314/AMBARI-17898-trunk_2.patch
          against trunk revision .

          -1 patch. Top-level trunk compilation may be broken.

          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10260//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12849314/AMBARI-17898-trunk_2.patch against trunk revision . -1 patch . Top-level trunk compilation may be broken. Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10260//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12849314/AMBARI-17898-trunk_2.patch
          against trunk revision .

          -1 patch. Top-level trunk compilation may be broken.

          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10254//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12849314/AMBARI-17898-trunk_2.patch against trunk revision . -1 patch . Top-level trunk compilation may be broken. Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10254//console This message is automatically generated.
          Hide
          dsen Dmytro Sen added a comment -

          Uploaded updated patch to https://reviews.apache.org/r/55934/, For Suse agent start will fail with message "python-kerberos package need to be installed to run AMS in SPNEGO mode" if SPNEGO enabled and no python kerberos modules installed. If system has python kerberos modules installed, the agent will start successfully

          Show
          dsen Dmytro Sen added a comment - Uploaded updated patch to https://reviews.apache.org/r/55934/ , For Suse agent start will fail with message "python-kerberos package need to be installed to run AMS in SPNEGO mode" if SPNEGO enabled and no python kerberos modules installed. If system has python kerberos modules installed, the agent will start successfully
          Hide
          dili Di Li added a comment -

          Dmytro Sengreat, thank you !

          Show
          dili Di Li added a comment - Dmytro Sen great, thank you !
          Hide
          dsen Dmytro Sen added a comment -

          Di Li yes, I'll push it back after testing the patch on Suse.

          Show
          dsen Dmytro Sen added a comment - Di Li yes, I'll push it back after testing the patch on Suse.
          Hide
          dili Di Li added a comment -

          Dmytro Senhello Dmytro, sorry to bother you, would you be pushing the patch back to trunk and branch 2.5 since python-kerberos issue is fixed now ?

          Show
          dili Di Li added a comment - Dmytro Sen hello Dmytro, sorry to bother you, would you be pushing the patch back to trunk and branch 2.5 since python-kerberos issue is fixed now ?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Ambari-branch-2.5 #327 (See https://builds.apache.org/job/Ambari-branch-2.5/327/)
          Revert "AMBARI-17898 Add Kerberos HTTP SPNEGO authentication support to (dsen: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=191a62833afb871f70ff86d656e373c4061dc968)

          • (delete) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
          • (delete) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
          • (edit) ambari-metrics/ambari-metrics-assembly/pom.xml
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Ambari-branch-2.5 #327 (See https://builds.apache.org/job/Ambari-branch-2.5/327/ ) Revert " AMBARI-17898 Add Kerberos HTTP SPNEGO authentication support to (dsen: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=191a62833afb871f70ff86d656e373c4061dc968 ) (delete) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py (delete) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py (edit) ambari-metrics/ambari-metrics-assembly/pom.xml (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #6017 (See https://builds.apache.org/job/Ambari-trunk-Commit/6017/)
          Revert "AMBARI-17898 Add Kerberos HTTP SPNEGO authentication support to (dsen: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=a201d092d1dc4ef32dcbf3ba37ee957f33418637)

          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
          • (delete) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
          • (edit) ambari-metrics/ambari-metrics-assembly/pom.xml
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
          • (delete) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #6017 (See https://builds.apache.org/job/Ambari-trunk-Commit/6017/ ) Revert " AMBARI-17898 Add Kerberos HTTP SPNEGO authentication support to (dsen: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=a201d092d1dc4ef32dcbf3ba37ee957f33418637 ) (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py (delete) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py (edit) ambari-metrics/ambari-metrics-assembly/pom.xml (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 (delete) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
          Hide
          dsen Dmytro Sen added a comment -

          Reverted due to AMBARI-18896

          Show
          dsen Dmytro Sen added a comment - Reverted due to AMBARI-18896
          Hide
          dsen Dmytro Sen added a comment -

          Failed tests aren't related to the fix

          Show
          dsen Dmytro Sen added a comment - Failed tests aren't related to the fix
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Ambari-branch-2.5 #183 (See https://builds.apache.org/job/Ambari-branch-2.5/183/)
          AMBARI-17898 Add Kerberos HTTP SPNEGO authentication support to Ambari (dsen: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=02b3da7b71204298079e863806169cdaba78fc80)

          • (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini
          • (edit) ambari-metrics/ambari-metrics-assembly/pom.xml
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
          • (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Ambari-branch-2.5 #183 (See https://builds.apache.org/job/Ambari-branch-2.5/183/ ) AMBARI-17898 Add Kerberos HTTP SPNEGO authentication support to Ambari (dsen: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=02b3da7b71204298079e863806169cdaba78fc80 ) (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini (edit) ambari-metrics/ambari-metrics-assembly/pom.xml (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py
          Hide
          dsen Dmytro Sen added a comment -

          Committed to trunk and branch-2.5

          Show
          dsen Dmytro Sen added a comment - Committed to trunk and branch-2.5
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #5840 (See https://builds.apache.org/job/Ambari-trunk-Commit/5840/)
          AMBARI-17898 Add Kerberos HTTP SPNEGO authentication support to Ambari (dsen: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=18a88ebb43260f01ff1b5370bc15fb7b6a64055c)

          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
          • (edit) ambari-metrics/ambari-metrics-assembly/pom.xml
          • (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini
          • (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
          • (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
          • (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #5840 (See https://builds.apache.org/job/Ambari-trunk-Commit/5840/ ) AMBARI-17898 Add Kerberos HTTP SPNEGO authentication support to Ambari (dsen: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=18a88ebb43260f01ff1b5370bc15fb7b6a64055c ) (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py (edit) ambari-metrics/ambari-metrics-assembly/pom.xml (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py (edit) ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini (add) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py (edit) ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json (edit) ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py (edit) ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12833958/AMBARI-17898-trunk.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The test build failed in ambari-server

          Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8903//testReport/
          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8903//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12833958/AMBARI-17898-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The test build failed in ambari-server Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8903//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8903//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12833958/AMBARI-17898-trunk.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in ambari-server.

          Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8902//testReport/
          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8902//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12833958/AMBARI-17898-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8902//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8902//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12833154/AMBARI-17898_branch-2.5.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8869//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12833154/AMBARI-17898_branch-2.5.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8869//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12829851/AMBARI-17898.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The test build failed in ambari-server

          Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8728//testReport/
          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8728//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12829851/AMBARI-17898.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The test build failed in ambari-server Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8728//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8728//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12829851/AMBARI-17898.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in ambari-server.

          Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8710//testReport/
          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8710//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12829851/AMBARI-17898.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8710//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8710//console This message is automatically generated.
          Hide
          qinliu Qin Liu added a comment -

          Not sure why previous patch sit there for 2 days and didn't get tested.
          so I have to rebase and submit it again

          Show
          qinliu Qin Liu added a comment - Not sure why previous patch sit there for 2 days and didn't get tested. so I have to rebase and submit it again
          Hide
          qinliu Qin Liu added a comment -

          Thanks you so much Robert! Will correct it.

          Show
          qinliu Qin Liu added a comment - Thanks you so much Robert! Will correct it.
          Hide
          rlevas Robert Levas added a comment - - edited

          For the HTTP protocol, it is expected at the web-server side of the equation uses HTTP/_HOST, but the client side should use a relevant identity. In this case the client should use something like ams/_HOST or ams_monitor/_HOST.

          Show
          rlevas Robert Levas added a comment - - edited For the HTTP protocol, it is expected at the web-server side of the equation uses HTTP/_HOST , but the client side should use a relevant identity. In this case the client should use something like ams/_HOST or ams_monitor/_HOST .
          Hide
          qinliu Qin Liu added a comment -

          hadoop rpc uses hostname based principals. However, for HTTP protocol, it has been SPNEGO principal. Both are correct though. depending on how the system was configured.
          What the service that Metrics monitor tries to access is the Metrics collector web server.

          Show
          qinliu Qin Liu added a comment - hadoop rpc uses hostname based principals. However, for HTTP protocol, it has been SPNEGO principal. Both are correct though. depending on how the system was configured. What the service that Metrics monitor tries to access is the Metrics collector web server.
          Hide
          rlevas Robert Levas added a comment -

          Qin Liu...

          I think this is incorrect. The Metrics Monitor should authenticate with its own service principal, not the SPNEGO principal. That is used for web-based services, like Ambari's web-based interface. There should be an ams/_HOST principal for this, instead.

          Show
          rlevas Robert Levas added a comment - Qin Liu ... I think this is incorrect. The Metrics Monitor should authenticate with its own service principal, not the SPNEGO principal. That is used for web-based services, like Ambari's web-based interface. There should be an ams/_HOST principal for this, instead.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12827453/AMBARI-17898.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in ambari-server.

          Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8607//testReport/
          Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8607//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12827453/AMBARI-17898.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8607//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8607//console This message is automatically generated.

            People

            • Assignee:
              qinliu Qin Liu
              Reporter:
              qinliu Qin Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development