[AMBARI-17550] While changing NN, DN directories from UI, proper warning should be present for invalid values

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.4.0
• Assignee: Andrew Onischuk
• Reporter: Andrew Onischuk
• Created: 04/Jul/16 13:11
• Updated: 07/Jul/16 11:27
• Resolved: 07/Jul/16 09:45

Description

While changing NN and DN directories from ambari, for example:
changing dn directories from */grid/0/hadoop/hdfs/data* to **/grid/0/hadoop/
hdfs/data,/grid/0/hadoop/hdfs/data1,/grid/0/hadoop/hdfs/data2**

The values are changed without being validated
This leads to datanodes start failing

Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py", line 174, in <module>
DataNode().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 280, in execute
method(env)
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 709, in restart
self.start(env, upgrade_type=upgrade_type)
File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py", line 60, in start
self.configure(env)
File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py", line 55, in configure
datanode(action="configure")
File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
return fn(*args, **kwargs)
File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py", line 53, in datanode
data_dir_to_mount_file_content = handle_mounted_dirs(create_dirs, params.dfs_data_dirs, params.data_dir_mount_file, params)
File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/mounted_dirs_helper.py", line 158, in handle_mounted_dirs
raise Fail(message + " . Please turn off cluster-env/one_dir_per_partition or handle the situation manually.")
resource_management.core.exceptions.Fail: Trying to create another directory on the following mount: /grid/0 . Please turn off cluster-env/one_dir_per_partition or handle the situation manually.

The test fails because it set invalid value, and the directory was not created
A warning message informing why the new directory name is invalid could be
useful

Issue Links

• links to: ReviewBoard