[AMBARI-16094] Improvements to DB consistency check

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.4.0
• Component/s: ambari-server
• Assignee: Vitaly Brodetskyi
• Reporter: Vitaly Brodetskyi
• Created: 25/Apr/16 15:16
• Updated: 04/May/16 16:33
• Resolved: 04/May/16 12:32

Description

• disable (we can remove later) DatabaseCheck
• Have CheckDatabaseHelper be called as part of ambari-server start
  • Modify ambari-server start to so that it calls ambari-server check-database

ambari-server check-database improvements

• On the output modify Ambari Server 'check-database' completed successfully. to Ambari Server 'check-database' completed. - remove successfully
• Use “--skip-database-check” (not skip-database-validation) to force ambari-server to start despite error
• If there is error when check-database is run then use the following text

  DB configs consistency check failed. Run “ambari-server start --skip-database-check” to skip. If you use this “--skip-database-check” option, do not make any changes to your cluster topology or perform a cluster upgrade until you correct the database consistency issues. See "/var/log/ambari-server/ambari-check-database.log" for more details on the consistency issues.
  

ambari-server start improvements

• On Ambari Server start, the output failure text to should mention ambari-server.log (in addition to .out file it does today)
• If user has not specified --skip-database-check fail start command if check-database reports error
• When user starts server with --skip-database-check, if there are DB check errors, print message:

  Ambari Server is starting with the database consistency check skipped. Do not make any changes to your cluster topology or perform a cluster upgrade until you correct the database consistency issues. See "/var/log/ambari-server/ambari-check-database.log" for more details on the consistency issues.
  

When using log file paths, make sure to use the right path from log4j.

Optional
Modify ambari.properties to add database_check_error_skipped=true if user started with --skip-database-check and there were errors due to database-check. If there are no errors then store database_check_error_skipped=false. Eventually, UI will use this property and show warnings to the user and even prevent HDP upgrade or other topology modifying operations such as Add Host/Service.

Issue Links

• links to: review request