[AMBARI-13075] Make ambari-server robust/debuggable if user accidentally adds a config type to a config groups when it does not exist as base type

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.2
• Assignee: Andrew Onischuk
• Reporter: Andrew Onischuk
• Created: 11/Sep/15 14:23
• Updated: 11/Sep/15 20:14
• Resolved: 11/Sep/15 14:30

Description

This was reported by a customer. Customer accidentally added a config of type
`hivesite` to a config group.

*Call*

curl 'http://ambhost:8080/api/v1/clusters/TSGHDP/config_groups/3' -X PUT -H "X-Requested-By: ambari" --user admin:admin --data '[{"ConfigGroup":{"id":3,"cluster_name":"HDP","group_name":"Hive_custom_group","tag":"HIVE","description":"","hosts":[

{"host_name":"abc.local"}

],"service_config_version_note":"hive custom group tx timeout
property change","desired_configs":[{"type":"hivesite","tag":"newversionforjdbcurl","properties":{"hive.txn.timeout":"310","javax.jdo.option.ConnectionURL":"jdbc:mysql://abc.local/hive2?createDatabaseIfNotExist=true"}}]}}]' --compressed

This resulted in ambari-server failing to process agent heartbeat and throwing
NPE.

13 Aug 2015 10:36:28,961 WARN [ambari-hearbeat-monitor] HeartbeatMonitor:129 - Exception received
java.lang.NullPointerException
at org.apache.ambari.server.state.host.HostImpl.getDesiredHostConfigs(HostImpl.java:1349)
at org.apache.ambari.server.state.ConfigHelper.getEffectiveDesiredTags(ConfigHelper.java:109)
at org.apache.ambari.server.agent.HeartbeatMonitor.createStatusCommand(HeartbeatMonitor.java:253)
at org.apache.ambari.server.agent.HeartbeatMonitor.generateStatusCommands(HeartbeatMonitor.java:218)
at org.apache.ambari.server.agent.HeartbeatMonitor.doWork(HeartbeatMonitor.java:190)
at org.apache.ambari.server.agent.HeartbeatMonitor.run(HeartbeatMonitor.java:121)
at java.lang.Thread.run(Thread.java:745)

Issue Links

• links to: ReviewBoard