[AMBARI-12429] Deleting a host using the API causes NPE

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 2.1.1
• Component/s: ambari-server
• Assignee: Alejandro Fernandez
• Reporter: Alejandro Fernandez
• Created: 15/Jul/15 22:35
• Updated: 17/Jul/15 08:09
• Resolved: 17/Jul/15 06:29

Description

There are 3 issues while deleting hosts.
1. Created a cluster with multiple hosts, then stopped all of the services on 1 host (preferably one with only clients so it has nothing to stop). Then deleted the host using the API.
E.g., curl -u admin:admin -H "X-Requested-By: ambari" -X DELETE http://c6401.ambari.apache.org:8080/api/v1/hosts/c6404.ambari.apache.org
This led to Null Pointer Exceptions in ambari-server because the UI is still generating requests to get the ServiceComponentHost response, which isn't locking code, and makes request to get the HostState (this record has been deleted), so a NPE is thrown. This needs to be more robust; adding locks around here may have other repercussions, so I decided to just check for != null.

2. If a Host with DataNode becomes decommissioned, it will have a record in the requestoperationlevel table, whose records are not currently being deleted when a Host is deleted.

3. There are differences between deleting a Host using the /hosts/name and /clusters/name/hosts/name API. In the former, since no cluster is provided, it blindly deletes the host without checking if it has any masters/slaves on it, which need to be stopped and deleted first.

ambari-server-2.1.0-2480.x86_64
ambari-server --hash
7d0fd97cc697b22357f4c499b80b8baf9a1c1dbc

Issue Links

• links to: Code Review patch