Uploaded image for project: 'Apache Airflow'
  1. Apache Airflow
  2. AIRFLOW-4097

Password printed out when adding connection

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.10.2
    • Fix Version/s: None
    • Component/s: cli, security
    • Labels:
      None
    • Environment:
      Docker/Debian

      Description

      What happens

      When adding a connection, including a password, via the airflow cli the password is printed to stdout.

      Expected behaviour

      Password is masked when printing to screen.

      Example how it is today

      $ airflow connections -a --conn_id slack --conn_host=https://hooks.slack.com/services --conn_type=http --conn_password=MYPASSWORD
      [2019-03-15 12:47:06,397] {settings.py:174} INFO - settings.configure_orm(): Using pool settings. pool_size=5, pool_recycle=1800, pid=228
      [2019-03-15 12:47:06,880] {_init_.py:51} INFO - Using executor LocalExecutor
      [2019-03-15 12:47:07,890] {models.py:169} WARNING - empty cryptography key - values will not be stored encrypted.Successfully added `conn_id`=slack : http://:MYPASSWORD@https://hooks.slack.com/services:

      MYPASSWORD shall not be printed on the last line.

      Expected output

      $ airflow connections -a --conn_id slack --conn_host=https://hooks.slack.com/services --conn_type=http --conn_password=MYPASSWORD
      [2019-03-15 12:47:06,397] {settings.py:174} INFO - settings.configure_orm(): Using pool settings. pool_size=5, pool_recycle=1800, pid=228
      [2019-03-15 12:47:06,880] {_init_.py:51} INFO - Using executor LocalExecutor
      [2019-03-15 12:47:07,890] {models.py:169} WARNING - empty cryptography key - values will not be stored encrypted.Successfully added `conn_id`=slack : *http://:******@https*://hooks.slack.com/services:

      MYPASSWORD is here replaced with a number of * on the last line.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              magru Magnus Runesson
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: