Uploaded image for project: 'Apache Airflow'
  1. Apache Airflow
  2. AIRFLOW-2921

A trivial incorrectness in CeleryExecutor()

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.10.1
    • Component/s: None
    • Labels:
      None

      Description

      Code: https://github.com/apache/incubator-airflow/blob/62bd68999bade4261daf0499b56098d2e6fc9470/airflow/executors/celery_executor.py#L108

      The logic here is: if a task state becomes either SUCCESS or FAILURE or REVOKED, it will be removed from self.tasks() and self.last_state(). However, because line108 is not indented properly, this task will be added back to self.last_state() again.

      This will not lead to any error. But may still be worth changing.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                XD-DENG Xiaodong DENG
                Reporter:
                XD-DENG Xiaodong DENG
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: