Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
Description
The user storage browser automatically tries to download files that are the right type to preview but doesn't check their size first. So with a large file, it attempts to load the entire file into the codemirror editor and this causes the browser to hang.
The file size should be checked first and no preview/edit offered for large files.
Somewhat arbitrarily I chose a large file cutoff of 1MB. We can easily adjust as necessary: https://github.com/apache/airavata-django-portal/blob/develop/django_airavata/apps/workspace/static/django_airavata_workspace/js/components/storage/storage-edit/UserStorageTextEditViewer.vue#L36
TODO
- [x] add a get_data_product_metadata function to user_storage, similar to get_file_metadata but taking a data_product or data_product_uri
- [x] add a check in UserStorageTextEditViewer.vue to load the filesize first and display a message if the file is too large, otherwise load the file into the editor like it is currently doing
- [x] add gzip compression to file download ( in api and in SDK)
- [x] add owner_username override to get_data_product_metadata
- [x] Want to revisit how the UI handles disabling preview for large files.
Attachments
Issue Links
- is related to
-
AIRAVATA-3489 Cannot read property 'getWrapperElement' of null: "\"destroyed hook\""
- Resolved