[AIRAVATA-3276] BUG: non uploaded files argument appears in command-line in job script

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.18
• Fix Version/s: 0.19
• Component/s: Django Portal
• Environment: https://seagrid.org/
• Assignee: Anna Branam
• Reporter: Eroma
• Created: 20/Nov/19 21:45
• Updated: 27/Apr/20 21:59
• Resolved: 10/Jan/20 20:05

Description

1. Created new application ABAQUS-6.14-1
2. In this application a file need to be uploaded as optional file.
3. This particular input also has an argument.
4. When the file is not uploaded the argument appears in command-line without the file.
5. The argument should only appear with the filename when the file is uploaded.

TODO

• Update backend to ignore inputs with requiredToAddedToCommandLine=true when value is null or empty and isRequired=false
• Automatically add "showOptions" configuration for toggling isRequired
• Change "showOptions" metadata to

  {"showOptions": {"isRequired": true}}

  with data migration

  • need backwards compatibility with old schema in code

Production rollout

• deploy backend changes - https://github.com/apache/airavata/tree/airavata-3276
• deploy frontend changes - https://github.com/apache/airavata-django-portal/tree/AIRAVATA-3276--BUG--non-uploaded-files-argument-appears-in-command-line-in-job-script
• run data migration script for frontend changes

Summary

With these changes in place, admins no longer need to add special configuration for dependent inputs that have isRequired=true or requiredToAddedToCommandLine=true. The application interface editor will automatically add

{"showOptions": {"isRequired": true}}

to the JSON configuration for a dependent input.