[ACCUMULO-4716] Do not attempt to cache blocks over max array size

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.4, 1.9.0
• Labels: newbie pull-request-available
• Assignee: Mark Owens
• Reporter: Keith Turner
• Created: 04/Oct/17 17:40
• Updated: 23/Apr/19 16:12
• Resolved: 12/Oct/17 23:48

Description

One might think you could do new byte[Integer.MAX_VALUE] in Java, but as I found when looking into ACCUMULO-4708 suprise you can't.

According to the stack overflow post new byte[Integer.MAX_VALUE - 8] should be safe. I was able to do up to new byte[Integer.MAX_VALUE - 2] in my local testing.

When Accumulo caches a block it reads it into a byte array. For example this code in CachableBlockFile.java does this when _currBlock.getRawSize() <= cache.getMaxSize().

This code should ensure the size is less than min( cache.getMaxSize(), MAX_ARRAY_SIZE) inorder to read it into a byte array.

Issue Links

• links to: GitHub Pull Request #304