[ACCUMULO-4549] Remove duplicate init functions in TabletBalancer

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.7.3, 1.8.1, 2.0.0
• Labels: release_notes
• Assignee: Christopher Tubbs
• Reporter: Adam J. Shook
• Created: 03/Jan/17 21:12
• Updated: 11/Jan/17 22:42
• Resolved: 11/Jan/17 22:42

Description

There are two init functions with similar signatures in the TabletLoadBalancer class that could result in an end-user overriding the wrong function and their object may never be initialized.

Master (1) calls the TabletBalancer#init(ServerConfigurationFactory) which is not what the regex load balancer is overriding (2), and the TabletBalancer doesn't call the other init function (3).

Come up with a plan for compatibility and remove the duplicate functions.

(1) https://github.com/apache/accumulo/blob/1.7/server/master/src/main/java/org/apache/accumulo/master/Master.java#L589
(2) https://github.com/apache/accumulo/blob/1.7/server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java#L257
(3) https://github.com/apache/accumulo/blob/1.7/server/base/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java#L57

Issue Links

• relates to: ACCUMULO-4535 HostRegexTableLoadBalancer fails with NullPointerException