Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-4549

Remove duplicate init functions in TabletBalancer

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.3, 1.8.1, 2.0.0
    • Component/s: None
    • Labels:

      Description

      There are two init functions with similar signatures in the TabletLoadBalancer class that could result in an end-user overriding the wrong function and their object may never be initialized.

      Master (1) calls the TabletBalancer#init(ServerConfigurationFactory) which is not what the regex load balancer is overriding (2), and the TabletBalancer doesn't call the other init function (3).

      Come up with a plan for compatibility and remove the duplicate functions.

      (1) https://github.com/apache/accumulo/blob/1.7/server/master/src/main/java/org/apache/accumulo/master/Master.java#L589
      (2) https://github.com/apache/accumulo/blob/1.7/server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java#L257
      (3) https://github.com/apache/accumulo/blob/1.7/server/base/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java#L57

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ctubbsii Christopher Tubbs
                Reporter:
                adamjshook Adam J Shook
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h