Accumulo
  1. Accumulo
  2. ACCUMULO-442

Please add comments to src/trace/thift.sh

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.0
    • Component/s: None
    • Labels:

      Description

      I'm poking about the source code and found this script. It is probably used to generate Java files from a Thrift template? Can someone please add a comment or two to the file to indicate when it should be run. And what is is doing? Does Thrift normally install and call itself 'thrift0.6'?

        Activity

        Hide
        Eric Newton added a comment -

        I don't think there's a reason. The script in src/core only copies files over if they are different: you definitely want to preserve that behavior or eclipse will constantly recompile the files generated by thrift.

        Show
        Eric Newton added a comment - I don't think there's a reason. The script in src/core only copies files over if they are different: you definitely want to preserve that behavior or eclipse will constantly recompile the files generated by thrift.
        Hide
        David Medinets added a comment -

        Is there any reason why this script should not delete the contents of the src/trace/src/main/java/cloudtrace/thrift directory for each run of the script? Is anything in that directory other than thrift-generated files?

        Show
        David Medinets added a comment - Is there any reason why this script should not delete the contents of the src/trace/src/main/java/cloudtrace/thrift directory for each run of the script? Is anything in that directory other than thrift-generated files?
        Hide
        Eric Newton added a comment -

        You're right, there are sometimes issues. I just had problems building when the package name changed for the cloudtrace stuff. Fortunately, the thrift calls change so infrequently, that we just deal with it manually. But, if you wanted to do something better, that would be great.

        I would like to look at Avro, too. Maybe something to experiment for 1.5. We'll be moving up to the latest version of thrift, at least, and that will require some changes to the tracing stuff.

        Show
        Eric Newton added a comment - You're right, there are sometimes issues. I just had problems building when the package name changed for the cloudtrace stuff. Fortunately, the thrift calls change so infrequently, that we just deal with it manually. But, if you wanted to do something better, that would be great. I would like to look at Avro, too. Maybe something to experiment for 1.5. We'll be moving up to the latest version of thrift, at least, and that will require some changes to the tracing stuff.
        Hide
        David Medinets added a comment -

        The comments look great. They lead me to my next question. The script does not delete old generated Java files. I don't know much about Thift. Could it be possible for the templates to have changed so that some generated Java files are no longer needed? How would they be managed?

        Show
        David Medinets added a comment - The comments look great. They lead me to my next question. The script does not delete old generated Java files. I don't know much about Thift. Could it be possible for the templates to have changed so that some generated Java files are no longer needed? How would they be managed?
        Hide
        jv added a comment -

        David - if that meets your standards, go ahead and close it. If not, let me know what needs clarification

        Show
        jv added a comment - David - if that meets your standards, go ahead and close it. If not, let me know what needs clarification

          People

          • Assignee:
            David Medinets
            Reporter:
            David Medinets
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development