[ACCUMULO-4083] TabletServerResourceManager doesn't sanity check memory settings if native maps are being used

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.6.4
• Fix Version/s: 1.6.5, 1.7.1, 1.8.0
• Component/s: tserver
• Assignee: Josh Elser
• Reporter: William Slacum
• Created: 17/Dec/15 23:32
• Updated: 22/Dec/15 21:48
• Resolved: 22/Dec/15 21:48

Description

Noticed that the TServer tries to fail fast if caches and memory maps are configured to use more memory than the JVM has given to it via -Xmx. However, if native maps are being used, this check fails. I recently had OOMEs kill TServers because their data block cache was 16gb and the max heap was 16gb.

Here's the check:

TabletServerResourceManager.java

    Runtime runtime = Runtime.getRuntime();
    if (!usingNativeMap && maxMemory + dCacheSize + iCacheSize > runtime.maxMemory()) {
      throw new IllegalArgumentException(String.format(
          "Maximum tablet server map memory %,d and block cache sizes %,d is too large for this JVM configuration %,d", maxMemory, dCacheSize + iCacheSize,
          runtime.maxMemory()));
    }

I think the check should still happen for index and data caches if native maps are being used.