[ACCUMULO-4067] TTimeoutTransport repeatedly uses reflection to obtain method

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.5, 1.7.1, 1.8.0
• Component/s: rpc
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 30/Nov/15 17:21
• Updated: 04/Dec/15 21:30
• Resolved: 04/Dec/15 21:30

Description

Noticed the following in TTimeoutTransport while looking at ACCUMULO-4065:

  private static InputStream getInputStream(Socket socket, long timeout) {
    try {
      Method m = NetUtils.class.getMethod("getInputStream", Socket.class, Long.TYPE);
      return (InputStream) m.invoke(null, socket, timeout);
    } catch (Exception e) {
      throw new RuntimeException(e);
    }
  }

We should really just invoke getMethod once and cache the Method instance instead of repeatedly getting it every time we create a new connection (which is often).

Not sure if this is a "hot" enough code path to have a noticeable performance impact, but it should be good to fix regardless.