[ACCUMULO-4037] avoid a key copy in TimeSettingIterator

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.7.1, 1.8.0
• Component/s: core
• Labels: performance
• Assignee: Josh Elser
• Reporter: Adam Fuchs
• Created: 22/Oct/15 18:22
• Updated: 25/Oct/15 01:15
• Resolved: 25/Oct/15 01:15

Description

In org.apache.accumulo.core.iterators.system.TimeSettingIterator we make a copy of the key before setting the time. Seems like this is a completely superfluous copy, and we should avoid it. In the current code we do the following:

  @Override
  public Key getTopKey() {
    Key key = new Key(source.getTopKey());
    key.setTimestamp(time);
    return key;
  }

Instead we should do this:

  @Override
  public Key getTopKey() {
    Key key = source.getTopKey();
    key.setTimestamp(time);
    return key;
  }