Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-3866

TraceScope not closed

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.7.0
    • Fix Version/s: 1.7.1, 1.8.0
    • Component/s: trace
    • Labels:

      Description

      Two cases in which TraceScope is returned but never closed (it implements Closeable.

      core/.../Trace.java
        public static void off() {
          org.apache.htrace.Span span = org.apache.htrace.Trace.currentSpan();
          if (span != null) {
            span.stop();
            org.apache.htrace.Tracer.getInstance().continueSpan(null);
          }
        }
      
      trace/.../Trace.java
        public static void endThread(Span span) {
          if (span != null) {
            span.stop();
            org.apache.htrace.Tracer.getInstance().continueSpan(null);
          }
        }
      

      [~billie.rinaldi] do you know if there's a reason that these aren't getting closed or is it just a bug?

        Attachments

          Activity

            People

            • Assignee:
              elserj Josh Elser
              Reporter:
              elserj Josh Elser
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m