Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-2615 Simplify server configuration caching and ZK watchers
  3. ACCUMULO-3081

ServerConfigurationFactoryTest is full of commented out and unused code

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 1.6.1, 1.7.0
    • None
    • None

    Description

      Commented out code is not good to leave in. It creates readability and maintainability problems, such as questions about how current it is, and whether the reasons for commenting it out are still valid.

      This code should be removed from ServerConfigurationFactoryTest.

      If there is a unit test which is broken in some way and needs to be disabled until some other problem is fixed, it should reference the relevant JIRA (ideally, which references the relevant code in return, so any contributor working on that issue knows it's there) and use the @Ignore annotation to disable.

      Attachments

        Activity

          People

            ctubbsii Christopher Tubbs
            ctubbsii Christopher Tubbs
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m