[ACCUMULO-2910] Ineffective null check for replicationSources in Mutation#write()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: replication
• Assignee: Josh Elser
• Reporter: Ted Yu
• Created: 15/Jun/14 01:22
• Updated: 15/Jun/14 03:05
• Resolved: 15/Jun/14 03:05

Description

    if (!replicationSources.isEmpty()) {
      // Use 2nd least-significant bit for whether or not we have replication sources
      hasValues = (byte) (0x02 | hasValues);
    }
...
    if (0x02 == (0x02 & hasValues)) {
      if (null == replicationSources) {

The null check in 'if (0x02' block is ineffective - replicationSources was dereferenced earlier.