[ACCUMULO-2870] Potential null pointer dereference in Tablet#longestCommonLength()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.1, 1.6.0
• Fix Version/s: 1.5.2, 1.6.1, 1.7.0
• Assignee: Josh Elser
• Reporter: Ted Yu
• Created: 06/Jun/14 20:38
• Updated: 23/Jul/14 16:08
• Resolved: 23/Jul/14 16:08

Description

longestCommonLength() is called by findSplitRow():

      Text text = (mid == null) ? null : mid.getRow();
      SortedMap<Double,Key> firstHalf = keys.headMap(.5);
      if (firstHalf.size() > 0) {
        Text beforeMid = firstHalf.get(firstHalf.lastKey()).getRow();
        Text shorter = new Text();
        int trunc = longestCommonLength(text, beforeMid);

If mid is null, text would be null.
However, text is dereferenced without null check in longestCommonLength().