Accumulo
  1. Accumulo
  2. ACCUMULO-2733

Credentials is missing deserializer to match Thrift serializer

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Right now Credentials has a toThrift method that serializes to a TCredential, but no corresponding fromThrift to deserialize. Instead there are several locations that inline this deserialization.

      To avoid maintaining multiple implementations, these should be consolidated into a single fromThrift method.

        Issue Links

          Activity

          Sean Busbey created issue -
          Sean Busbey made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Sean Busbey made changes -
          Remote Link This issue links to "reviewboard (Web Link)" [ 14933 ]
          Sean Busbey made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Hide
          Sean Busbey added a comment -

          result of RB feedback

          Show
          Sean Busbey added a comment - result of RB feedback
          Sean Busbey made changes -
          Attachment ACCUMULO-2733.1.patch.txt [ 12641932 ]
          Hide
          ASF subversion and git services added a comment -

          Commit 6742627f20ad58e8e0737baddde952d9d7edba87 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Sean Busbey
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6742627 ]

          ACCUMULO-2733 adds thrift deserialization to Credentials

          Show
          ASF subversion and git services added a comment - Commit 6742627f20ad58e8e0737baddde952d9d7edba87 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Sean Busbey [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6742627 ] ACCUMULO-2733 adds thrift deserialization to Credentials
          Hide
          ASF subversion and git services added a comment -

          Commit 6742627f20ad58e8e0737baddde952d9d7edba87 in accumulo's branch refs/heads/master from Sean Busbey
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6742627 ]

          ACCUMULO-2733 adds thrift deserialization to Credentials

          Show
          ASF subversion and git services added a comment - Commit 6742627f20ad58e8e0737baddde952d9d7edba87 in accumulo's branch refs/heads/master from Sean Busbey [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=6742627 ] ACCUMULO-2733 adds thrift deserialization to Credentials
          Sean Busbey made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          ASF subversion and git services added a comment -

          Commit e450d74aec76b751a3c2bc9ff12cd7da547f14f1 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Sean Busbey
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e450d74 ]

          ACCUMULO-2733 clean up one missed unused import.

          Show
          ASF subversion and git services added a comment - Commit e450d74aec76b751a3c2bc9ff12cd7da547f14f1 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Sean Busbey [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e450d74 ] ACCUMULO-2733 clean up one missed unused import.
          Hide
          ASF subversion and git services added a comment -

          Commit e450d74aec76b751a3c2bc9ff12cd7da547f14f1 in accumulo's branch refs/heads/master from Sean Busbey
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e450d74 ]

          ACCUMULO-2733 clean up one missed unused import.

          Show
          ASF subversion and git services added a comment - Commit e450d74aec76b751a3c2bc9ff12cd7da547f14f1 in accumulo's branch refs/heads/master from Sean Busbey [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e450d74 ] ACCUMULO-2733 clean up one missed unused import.
          Christopher Tubbs made changes -
          Fix Version/s 1.6.0 [ 12322468 ]
          Fix Version/s 1.7.0 [ 12324607 ]
          Fix Version/s 1.6.1 [ 12325441 ]
          Christopher Tubbs made changes -
          Affects Version/s 1.6.0 [ 12322468 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          11s 1 Sean Busbey 25/Apr/14 00:13
          In Progress In Progress Patch Available Patch Available
          7h 54m 1 Sean Busbey 25/Apr/14 08:08
          Patch Available Patch Available Resolved Resolved
          8h 25m 1 Sean Busbey 25/Apr/14 16:33

            People

            • Assignee:
              Sean Busbey
              Reporter:
              Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development