Accumulo
  1. Accumulo
  2. ACCUMULO-2726

Maintain binary backwards compat for non-deprecated API components for 1.5 -> 1.6

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: client
    • Labels:
      None

      Description

      a JAPI compliane scan comparing 1.5.0 to 1.6.0-SNAPSHOT showed several incompatibilities in classes that probably never should have been in the public API

      • client.admin.SecurityOperationsImpl
      • client.admin.TableOperationsImpl
      • client.admin.InstanceOparationsImpl
      • client.mock.MockShell
      • client.mock.MockTabletLocator

      These changes are due to refactorings outside of the public API leaking into classes within the client that handle implementation.

      Since we're likely to break compatibility in the release after 1.6.0, try not to do it this time. Make sure to deprecate all these things, just in case there's a 1.7.0

      1. ACCUMULO-2726.3.patch.txt
        350 kB
        Sean Busbey
      2. ACCUMULO-2726.2.patch.txt
        350 kB
        Sean Busbey
      3. ACCUMULO-2726.1.patch.txt
        352 kB
        Sean Busbey

        Issue Links

          Activity

          Sean Busbey created issue -
          Sean Busbey made changes -
          Field Original Value New Value
          Assignee Sean Busbey [ busbey ]
          Sean Busbey made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Sean Busbey made changes -
          Summary Move implementation details out of public api Maintain binary backwards compat for non-deprecated API components for 1.5 -> 1.6
          Labels incompatible
          Fix Version/s 1.6.1 [ 12325441 ]
          Fix Version/s 1.6.0 [ 12322468 ]
          Affects Version/s 1.6.0 [ 12322468 ]
          Affects Version/s 1.4.0 [ 12318441 ]
          Affects Version/s 1.5.0 [ 12318645 ]
          Description a JAPI compliane scan comparing 1.5.0 to 1.6.0-SNAPSHOT showed several incompatibilities in classes that probably never should have been in the public API

          * client.admin.SecurityOperationsImpl
          * client.admin.TableOperationsImpl
          * client.admin.InstanceOparationsImpl
          * client.mock.MockShell
          * client.mock.MockTabletLocator

          These changes are due to refactorings outside of the public API leaking into classes within the client that handle implementation.

          For the next major release (i.e. 1.6.0) fix them to not be in the public API and include an apology in the release notes.

          We should also include other classes with names that end in Impl and other internal components of the Mock implementation.
          a JAPI compliane scan comparing 1.5.0 to 1.6.0-SNAPSHOT showed several incompatibilities in classes that probably never should have been in the public API

          * client.admin.SecurityOperationsImpl
          * client.admin.TableOperationsImpl
          * client.admin.InstanceOparationsImpl
          * client.mock.MockShell
          * client.mock.MockTabletLocator

          These changes are due to refactorings outside of the public API leaking into classes within the client that handle implementation.

          Since we're likely to break compatibility in the release after 1.6.0, try not to do it this time. Make sure to deprecate all these things, just in case there's a 1.7.0
          Sean Busbey made changes -
          Remote Link This issue links to "reviewboard (Web Link)" [ 14919 ]
          Sean Busbey made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Sean Busbey made changes -
          Attachment ACCUMULO-2726.1.patch.txt [ 12641935 ]
          Sean Busbey made changes -
          Attachment ACCUMULO-2726.2.patch.txt [ 12641937 ]
          Sean Busbey made changes -
          Attachment ACCUMULO-2726.3.patch.txt [ 12641945 ]
          Christopher Tubbs made changes -
          Fix Version/s 1.6.0 [ 12322468 ]
          Fix Version/s 1.6.1 [ 12325441 ]
          Christopher Tubbs made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Christopher Tubbs made changes -
          Affects Version/s 1.6.0 [ 12322468 ]

            People

            • Assignee:
              Sean Busbey
              Reporter:
              Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development