Accumulo
  1. Accumulo
  2. ACCUMULO-2726

Maintain binary backwards compat for non-deprecated API components for 1.5 -> 1.6

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: client
    • Labels:
      None

      Description

      a JAPI compliane scan comparing 1.5.0 to 1.6.0-SNAPSHOT showed several incompatibilities in classes that probably never should have been in the public API

      • client.admin.SecurityOperationsImpl
      • client.admin.TableOperationsImpl
      • client.admin.InstanceOparationsImpl
      • client.mock.MockShell
      • client.mock.MockTabletLocator

      These changes are due to refactorings outside of the public API leaking into classes within the client that handle implementation.

      Since we're likely to break compatibility in the release after 1.6.0, try not to do it this time. Make sure to deprecate all these things, just in case there's a 1.7.0

      1. ACCUMULO-2726.1.patch.txt
        352 kB
        Sean Busbey
      2. ACCUMULO-2726.2.patch.txt
        350 kB
        Sean Busbey
      3. ACCUMULO-2726.3.patch.txt
        350 kB
        Sean Busbey

        Issue Links

          Activity

          Hide
          Sean Busbey added a comment -

          presuming no one objects, I'm moving the *Helper classes as well (provided they don't leak in some other part of the API)

          Show
          Sean Busbey added a comment - presuming no one objects, I'm moving the *Helper classes as well (provided they don't leak in some other part of the API)
          Hide
          Sean Busbey added a comment -

          attaching the latest version from reviewboard. As stated there, if ACCUMULO-2733 goes in first, I'll modify this patch to rely on the methods it provides.

          Show
          Sean Busbey added a comment - attaching the latest version from reviewboard. As stated there, if ACCUMULO-2733 goes in first, I'll modify this patch to rely on the methods it provides.
          Hide
          Sean Busbey added a comment -

          patch updated to depend on ACCUMULO-2733

          Show
          Sean Busbey added a comment - patch updated to depend on ACCUMULO-2733
          Hide
          Sean Busbey added a comment -

          attaching updated patch based on feedback from Keith and Christopher

          Show
          Sean Busbey added a comment - attaching updated patch based on feedback from Keith and Christopher
          Hide
          ASF subversion and git services added a comment -

          Commit f4454a06567c1fd4ff8b9a374d633a42c23a8a80 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Sean Busbey
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f4454a0 ]

          ACCUMULO-2726 Adds back missing methods for binary backwards compat with non-Deprecated methods from 1.5.0. Marks things that we're for sure removing with @Deprecated; mostly things that shouldn't have been in public to begin with.

          Show
          ASF subversion and git services added a comment - Commit f4454a06567c1fd4ff8b9a374d633a42c23a8a80 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Sean Busbey [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f4454a0 ] ACCUMULO-2726 Adds back missing methods for binary backwards compat with non-Deprecated methods from 1.5.0. Marks things that we're for sure removing with @Deprecated; mostly things that shouldn't have been in public to begin with.
          Hide
          ASF subversion and git services added a comment -

          Commit 9bdad265990eb57ca7e101c0a3a446856798de55 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Sean Busbey
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=9bdad26 ]

          ACCUMULO-2726 missed a deprecation for part of Mock.

          Show
          ASF subversion and git services added a comment - Commit 9bdad265990eb57ca7e101c0a3a446856798de55 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Sean Busbey [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=9bdad26 ] ACCUMULO-2726 missed a deprecation for part of Mock.
          Hide
          ASF subversion and git services added a comment -

          Commit 9bdad265990eb57ca7e101c0a3a446856798de55 in accumulo's branch refs/heads/master from Sean Busbey
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=9bdad26 ]

          ACCUMULO-2726 missed a deprecation for part of Mock.

          Show
          ASF subversion and git services added a comment - Commit 9bdad265990eb57ca7e101c0a3a446856798de55 in accumulo's branch refs/heads/master from Sean Busbey [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=9bdad26 ] ACCUMULO-2726 missed a deprecation for part of Mock.
          Hide
          ASF subversion and git services added a comment -

          Commit f277fea98588b5e9f97d237a6479b9dfa08a37a1 in accumulo's branch refs/heads/master from Sean Busbey
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f277fea ]

          ACCUMULO-2726 cleanup for master's branch.

          • remove things we deprecated in 1.6.0 related to this ticket.
          • make sure changes in the implementations in master are reflected in the new implementation locations
          • make names in Mock consistent
          Show
          ASF subversion and git services added a comment - Commit f277fea98588b5e9f97d237a6479b9dfa08a37a1 in accumulo's branch refs/heads/master from Sean Busbey [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f277fea ] ACCUMULO-2726 cleanup for master's branch. remove things we deprecated in 1.6.0 related to this ticket. make sure changes in the implementations in master are reflected in the new implementation locations make names in Mock consistent

            People

            • Assignee:
              Sean Busbey
              Reporter:
              Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development