Accumulo
  1. Accumulo
  2. ACCUMULO-2663

Remove usage of String#split from Combiner#init

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.2, 1.6.1, 1.7.0
    • Component/s: None
    • Labels:

      Description

      Noticed that inside Combiner#init, the comma-separated list of columns is split out using the inefficient String#split method. This should be switched into something that doesn't used Regexs since this method is invoked a surprising amount in normal usage.

        Activity

        Hide
        David Protzman added a comment -

        Added ACCUMULO-2663.v1.patch. Using Guava's Splitter class to split instead of String.split()

        Show
        David Protzman added a comment - Added ACCUMULO-2663.v1.patch . Using Guava's Splitter class to split instead of String.split()
        Hide
        ASF subversion and git services added a comment -

        Commit a3a86412bcb00bb9ba68192c9425a026072e3562 in accumulo's branch refs/heads/1.5.2-SNAPSHOT from David Protzman
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8641 ]

        ACCUMULO-2663 - Remove usage of String#split from Combiner#init

        Noticed that inside Combiner#init, the comma-separated list of columns is split out using the inefficient String#split method. This should be switched into something that doesn't used Regexs since this method is invoked a surprising amount in normal usage.

        Signed-off-by: Josh Elser <elserj@apache.org>

        Show
        ASF subversion and git services added a comment - Commit a3a86412bcb00bb9ba68192c9425a026072e3562 in accumulo's branch refs/heads/1.5.2-SNAPSHOT from David Protzman [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8641 ] ACCUMULO-2663 - Remove usage of String#split from Combiner#init Noticed that inside Combiner#init, the comma-separated list of columns is split out using the inefficient String#split method. This should be switched into something that doesn't used Regexs since this method is invoked a surprising amount in normal usage. Signed-off-by: Josh Elser <elserj@apache.org>
        Hide
        ASF subversion and git services added a comment -

        Commit a3a86412bcb00bb9ba68192c9425a026072e3562 in accumulo's branch refs/heads/1.6.1-SNAPSHOT from David Protzman
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8641 ]

        ACCUMULO-2663 - Remove usage of String#split from Combiner#init

        Noticed that inside Combiner#init, the comma-separated list of columns is split out using the inefficient String#split method. This should be switched into something that doesn't used Regexs since this method is invoked a surprising amount in normal usage.

        Signed-off-by: Josh Elser <elserj@apache.org>

        Show
        ASF subversion and git services added a comment - Commit a3a86412bcb00bb9ba68192c9425a026072e3562 in accumulo's branch refs/heads/1.6.1-SNAPSHOT from David Protzman [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8641 ] ACCUMULO-2663 - Remove usage of String#split from Combiner#init Noticed that inside Combiner#init, the comma-separated list of columns is split out using the inefficient String#split method. This should be switched into something that doesn't used Regexs since this method is invoked a surprising amount in normal usage. Signed-off-by: Josh Elser <elserj@apache.org>
        Hide
        ASF subversion and git services added a comment -

        Commit a3a86412bcb00bb9ba68192c9425a026072e3562 in accumulo's branch refs/heads/master from David Protzman
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8641 ]

        ACCUMULO-2663 - Remove usage of String#split from Combiner#init

        Noticed that inside Combiner#init, the comma-separated list of columns is split out using the inefficient String#split method. This should be switched into something that doesn't used Regexs since this method is invoked a surprising amount in normal usage.

        Signed-off-by: Josh Elser <elserj@apache.org>

        Show
        ASF subversion and git services added a comment - Commit a3a86412bcb00bb9ba68192c9425a026072e3562 in accumulo's branch refs/heads/master from David Protzman [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8641 ] ACCUMULO-2663 - Remove usage of String#split from Combiner#init Noticed that inside Combiner#init, the comma-separated list of columns is split out using the inefficient String#split method. This should be switched into something that doesn't used Regexs since this method is invoked a surprising amount in normal usage. Signed-off-by: Josh Elser <elserj@apache.org>
        Hide
        Josh Elser added a comment -

        Thanks so much for the patch, David Protzman! I applied this to all active branches since it was very simple.

        Please let me know if you'd like to be listed on our contributor's list, optionally including timezone and/or employer details.

        Show
        Josh Elser added a comment - Thanks so much for the patch, David Protzman ! I applied this to all active branches since it was very simple. Please let me know if you'd like to be listed on our contributor's list , optionally including timezone and/or employer details.
        Hide
        ASF subversion and git services added a comment -

        Commit 3d469eb853a56ea5e1d0e15c049eb0284d2046c3 in accumulo's branch refs/heads/1.5.2-SNAPSHOT from Josh Elser
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3d469eb ]

        ACCUMULO-2663 Fix some compilation issues from guava deps

        Show
        ASF subversion and git services added a comment - Commit 3d469eb853a56ea5e1d0e15c049eb0284d2046c3 in accumulo's branch refs/heads/1.5.2-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3d469eb ] ACCUMULO-2663 Fix some compilation issues from guava deps
        Hide
        ASF subversion and git services added a comment -

        Commit 3d469eb853a56ea5e1d0e15c049eb0284d2046c3 in accumulo's branch refs/heads/1.6.1-SNAPSHOT from Josh Elser
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3d469eb ]

        ACCUMULO-2663 Fix some compilation issues from guava deps

        Show
        ASF subversion and git services added a comment - Commit 3d469eb853a56ea5e1d0e15c049eb0284d2046c3 in accumulo's branch refs/heads/1.6.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3d469eb ] ACCUMULO-2663 Fix some compilation issues from guava deps
        Hide
        ASF subversion and git services added a comment -

        Commit 3d469eb853a56ea5e1d0e15c049eb0284d2046c3 in accumulo's branch refs/heads/master from Josh Elser
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3d469eb ]

        ACCUMULO-2663 Fix some compilation issues from guava deps

        Show
        ASF subversion and git services added a comment - Commit 3d469eb853a56ea5e1d0e15c049eb0284d2046c3 in accumulo's branch refs/heads/master from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=3d469eb ] ACCUMULO-2663 Fix some compilation issues from guava deps

          People

          • Assignee:
            David Protzman
            Reporter:
            Josh Elser
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development