[ACCUMULO-2647] Replace String comparison if-then-else with switch

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0
• Fix Version/s: 1.7.0
• Component/s: start
• Labels: newbie summit2014
• Assignee: Jeffrey S Schwartz
• Reporter: Mike Drob
• Created: 07/Apr/14 20:17
• Updated: 13/Jun/14 00:13
• Resolved: 13/Jun/14 00:13

Description

In o.a.a.start.Main we have a giant if-then-else ladder for determining which class to use. With Java 7, we can replace this with a switch statement.

The switch statement compares the String object in its expression with the expressions associated with each case label as if it were using the String.equals method; consequently, the comparison of String objects in switch statements is case sensitive. The Java compiler generates generally more efficient bytecode from switch statements that use String objects than from chained if-then-else statements.

Issue Links

• is related to: ACCUMULO-1496 Use annotations to identify classes that are launchable by the start code