[ACCUMULO-2631] Excessively large number of minutes for trace page prints exception

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.1
• Fix Version/s: 1.5.2, 1.6.0
• Component/s: monitor
• Assignee: Josh Elser Assign to me
• Reporter: Josh Elser
• Created: 04/Apr/14 15:47
• Updated: 23/Apr/14 15:05
• Resolved: 05/Apr/14 01:47

Description

I wanted to get "all" the traces on my dev instance in the monitor so I changed the "minutes" query parameter to something like "99999".

When I submitted the page, I got an exception printed to the browser:

java.lang.IllegalArgumentException: Start key must be less than end key in range (start:1457aa24105 : [] 9223372036854775807 false, start:1452d6ac6a5%00; : [] 9223372036854775807 false)
	at org.apache.accumulo.core.data.Range.<init>(Range.java:166)
	at org.apache.accumulo.core.data.Range.<init>(Range.java:124)
	at org.apache.accumulo.core.data.Range.<init>(Range.java:95)
	at org.apache.accumulo.server.monitor.servlets.trace.Summary.pageBody(Summary.java:135)
	at org.apache.accumulo.server.monitor.servlets.BasicServlet.doGet(BasicServlet.java:61)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
	at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
	at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
	at org.mortbay.jetty.Server.handle(Server.java:326)
	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
	at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)

We should be catching this before it happens so we can print a meaningful error message. My hunch is that submitting a "minutes" value that's greater than the "number of minutes stored" is throwing this error – if that's the case, it would be nice to have an excessively large value just return everything.