Accumulo
  1. Accumulo
  2. ACCUMULO-2615

Simplify server configuration caching and ZK watchers

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.1, 1.7.0
    • Component/s: None
    • Labels:
      None

      Description

      The mechanism used for caching server-related configuration objects and processing ZK events could do with some simplification. For example:

      • The watcher objects obtain their corresponding configuration objects by reaching through the ServerConfiguration cache, instead of just having a more direct reference.
      • The watcher objects set log4j logging levels for both ZK and o.a.hadoop.io.compress to WARN, which prohibits debugging when needed. That should be done in log4j properties/XML instead.
      • Possible bug: NamespaceConfWatcher expires table configuration observers, not namespace configuration observers.
      • There is high duplication between the static and instance methods of ServerConfiguration. The class serves as both a cache container and a factory. Moreover, despite its name, it isn't actually a configuration object.

      I may be missing some subtleties of why things are as they are, so please fill me in as needed.

        Issue Links

          Activity

          Hide
          Eric Newton added a comment -

          Reopened until sub-tasks are complete.

          Show
          Eric Newton added a comment - Reopened until sub-tasks are complete.

            People

            • Assignee:
              Eric Newton
              Reporter:
              Bill Havanki
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2.5h
                2.5h

                  Development