[ACCUMULO-2511] Value allows equals(byte[])

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Labels: findbugs incompatible newbie
• Assignee: Unassigned
• Reporter: Sean Busbey
• Created: 20/Mar/14 20:03
• Updated: 14/Aug/19 17:10
• Resolved: 14/Aug/19 17:10

Description

Right now the equals(Object) method for Value is

 @Override
  public boolean equals(Object right_obj) {
    if (right_obj instanceof byte[]) {
      return compareTo((byte[]) right_obj) == 0;
    }
    if (right_obj instanceof Value) {
      return compareTo(right_obj) == 0;
    }
    return false;
  }

It's in a section that says it was copied from BytesWritable.

If we're not using this optimization anywhere, I'd rather remove it since it is non-intuitive.

If we are using it, I'd prefer we move it into something other than the general equals

Issue Links

• is duplicated by: ACCUMULO-2559 Value.equals implementation is not symmetric