Accumulo
  1. Accumulo
  2. ACCUMULO-958 Support pluggable encryption in walogs
  3. ACCUMULO-2452

DfsLogger.write(LogFileKey, LogFileValue) flushes with every call

        Details

        • Type: Sub-task Sub-task
        • Status: Resolved
        • Priority: Major Major
        • Resolution: Invalid
        • Affects Version/s: None
        • Fix Version/s: None
        • Component/s: tserver
        • Labels:
          None

          Description

          I was reviewing DfsLogger today and explaining how it works. I noticed that every write of every event calls flush() on output file. This should be unnecessary since the flush thread should do all the flush/sync operations. It may be necessary for the encryption stuff, but we'll need to figure out some sort of alternative implementation for non-encrypted output.

            Activity

            Hide
            Permalink
            John Vines added a comment - - edited

            It doesn't actually flush all the way down the stack. The loggers are wrapped in an output stream that catches the flush on that stream, so it doesn't affect normal operations.

            Show
            John Vines added a comment - - edited It doesn't actually flush all the way down the stack. The loggers are wrapped in an output stream that catches the flush on that stream, so it doesn't affect normal operations.

              People

              • Assignee:
                Eric Newton
                Reporter:
                Eric Newton
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development