Accumulo
  1. Accumulo
  2. ACCUMULO-2434

Functional test MapReduce runner doesn't check return code of test

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Won't Fix
    • Affects Version/s: 1.4.5, 1.5.1
    • Fix Version/s: None
    • Component/s: test
    • Labels:

      Description

      While testing ACCUMULO-2005, I had unusually fast MR test runs.

      Drilling into individual task results showed the run was actually failing while reporting the map task as successful.

      2014-03-05 10:52:27,755 INFO org.apache.accumulo.server.test.functional.RunTests: Running test [/usr/bin/python, test/system/auto/run.py, -m, -f, 1, -t, simple.addSplit.AddSplitTest]
      2014-03-05 10:52:27,788 INFO org.apache.accumulo.server.test.functional.RunTests: More: Traceback (most recent call last):
      2014-03-05 10:52:27,788 INFO org.apache.accumulo.server.test.functional.RunTests: More:   File "test/system/auto/run.py", line 29, in <module>
      2014-03-05 10:52:27,788 INFO org.apache.accumulo.server.test.functional.RunTests: More:     from TestUtils import ACCUMULO_HOME, ACCUMULO_DIR, COBERTURA_HOME, findCoberturaJar
      2014-03-05 10:52:27,788 INFO org.apache.accumulo.server.test.functional.RunTests: More: ImportError: No module named TestUtils
      2014-03-05 10:52:27,798 INFO org.apache.hadoop.mapred.MapTask: Starting flush of map output
      2014-03-05 10:52:27,811 INFO org.apache.hadoop.io.compress.CodecPool: Got brand-new compressor [.snappy]
      2014-03-05 10:52:27,814 INFO org.apache.hadoop.mapred.Task: Task:attempt_201401282254_0002_m_000003_0 is done. And is in the process of commiting
      2014-03-05 10:52:27,949 INFO org.apache.hadoop.mapred.Task: Task 'attempt_201401282254_0002_m_000003_0' done.
      

      the current test running class ignores the return code of the test process (ref)

      Instead, we should check the status and fail the task if it returns an error.

      Workaround: Job counters should show Success / Failure / Error count for tests. If none of hte counters appear, consider all tests failed.

        Activity

        Hide
        Christopher Tubbs added a comment -

        This issue was marked to be fixed for 1.5.3. However, no patch has been provided, and development on 1.5 is waning. Non-urgent issues are not likely to be addressed. Users are encouraged to upgrade to a newer version of Accumulo.

        Please re-open and update the affectedVersion and fixVersion if it affects a newer version of Accumulo.

        Show
        Christopher Tubbs added a comment - This issue was marked to be fixed for 1.5.3. However, no patch has been provided, and development on 1.5 is waning. Non-urgent issues are not likely to be addressed. Users are encouraged to upgrade to a newer version of Accumulo. Please re-open and update the affectedVersion and fixVersion if it affects a newer version of Accumulo.
        Hide
        Sean Busbey added a comment -

        Well, it helps by giving something to check for in the workaround.

        when all of the mappers fail, no counters get made and no records go to the reducer. In that case the job trivially succeeds.

        Show
        Sean Busbey added a comment - Well, it helps by giving something to check for in the workaround. when all of the mappers fail, no counters get made and no records go to the reducer. In that case the job trivially succeeds.
        Hide
        Bill Havanki added a comment -

        Does ACCUMULO-2380 help with this? It should be giving you counters at least, and a test report in the reducer output.

        Show
        Bill Havanki added a comment - Does ACCUMULO-2380 help with this? It should be giving you counters at least, and a test report in the reducer output.

          People

          • Assignee:
            Unassigned
            Reporter:
            Sean Busbey
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development