Accumulo
  1. Accumulo
  2. ACCUMULO-2350

Missing recommendation on replacement for deprecated client APIs

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: client
    • Labels:
      None

      Description

      Instance.getConfiguration was deprecated but doesn't inform the client as to what they should use instead.

      We should make sure that for things that we deprecate, we put a note there so that the client doesn't have to go digging or guess at what the proper replacement is.

        Issue Links

          Activity

          Hide
          Christopher Tubbs added a comment -

          It's difficult to recommend an alternative to something that never had a well-defined behavior. Is that the case here? Did this ever have well-defined (intended) behavior?

          Show
          Christopher Tubbs added a comment - It's difficult to recommend an alternative to something that never had a well-defined behavior. Is that the case here? Did this ever have well-defined (intended) behavior?
          Hide
          Josh Elser added a comment -

          The case I saw is that instance.getConfiguration was replaced by new ServerConfiguration(instance). If there's ambiguity, can't we still succiently make some sort of recommendation?

          Show
          Josh Elser added a comment - The case I saw is that instance.getConfiguration was replaced by new ServerConfiguration(instance) . If there's ambiguity, can't we still succiently make some sort of recommendation?
          Hide
          Josh Elser added a comment -

          AccumuloConfiguration.getSiteConfiguration() is another one that looks like it should inform of ServerConfiguration.getSiteConfiguration()

          Show
          Josh Elser added a comment - AccumuloConfiguration.getSiteConfiguration() is another one that looks like it should inform of ServerConfiguration.getSiteConfiguration()
          Hide
          John Vines added a comment -

          what in the client API should be using a ServerConfiguration?

          Show
          John Vines added a comment - what in the client API should be using a ServerConfiguration?
          Hide
          Josh Elser added a comment -

          Oops, forgot I put "client API" in the ticket name. That second one is just deprecation that doesn't suggest a replacement. Granted, I also don't even attempt to fake that I understand how AccumuloConfiguration and its extensions (were meant to) work

          Show
          Josh Elser added a comment - Oops, forgot I put "client API" in the ticket name. That second one is just deprecation that doesn't suggest a replacement. Granted, I also don't even attempt to fake that I understand how AccumuloConfiguration and its extensions (were meant to) work
          Hide
          Keith Turner added a comment -

          I was just panning on adding some documentation on why it was removed.
          There is no replacement, I think it was added for testing purposes. It
          should not have been there, its purpose was not well defined from a user
          perspective.

          Show
          Keith Turner added a comment - I was just panning on adding some documentation on why it was removed. There is no replacement, I think it was added for testing purposes. It should not have been there, its purpose was not well defined from a user perspective.
          Hide
          ASF subversion and git services added a comment -

          Commit 7b3567f853be562e0a326956b99752289d14a261 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7b3567f ]

          ACCUMULO-2350 add recommendation to use InstanceOperations methods to get/set server side configuration

          Show
          ASF subversion and git services added a comment - Commit 7b3567f853be562e0a326956b99752289d14a261 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7b3567f ] ACCUMULO-2350 add recommendation to use InstanceOperations methods to get/set server side configuration
          Hide
          ASF subversion and git services added a comment -

          Commit 7b3567f853be562e0a326956b99752289d14a261 in branch refs/heads/master from Eric Newton
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7b3567f ]

          ACCUMULO-2350 add recommendation to use InstanceOperations methods to get/set server side configuration

          Show
          ASF subversion and git services added a comment - Commit 7b3567f853be562e0a326956b99752289d14a261 in branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7b3567f ] ACCUMULO-2350 add recommendation to use InstanceOperations methods to get/set server side configuration
          Hide
          ASF subversion and git services added a comment -

          Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ]

          ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch

          Fixes trivial warnings and broken javadocs which have been recently
          introduced. Specifically, removes references to private and
          package-private (default) classes in public javadoc comments (internal
          details aren't relevant to the API and subject to change). Another
          common warning was unused imports and javadoc param tags that refer to
          non-existent parameters.

          Commits against the following JIRA issues introduced these:
          ACCUMULO-1948, ACCUMULO-1974, ACCUMULO-2021, ACCUMULO-2136,
          ACCUMULO-2322, ACCUMULO-2334, ACCUMULO-2350

          Show
          ASF subversion and git services added a comment - Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ] ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch Fixes trivial warnings and broken javadocs which have been recently introduced. Specifically, removes references to private and package-private (default) classes in public javadoc comments (internal details aren't relevant to the API and subject to change). Another common warning was unused imports and javadoc param tags that refer to non-existent parameters. Commits against the following JIRA issues introduced these: ACCUMULO-1948 , ACCUMULO-1974 , ACCUMULO-2021 , ACCUMULO-2136 , ACCUMULO-2322 , ACCUMULO-2334 , ACCUMULO-2350

            People

            • Assignee:
              Eric Newton
              Reporter:
              Josh Elser
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development