Accumulo
  1. Accumulo
  2. ACCUMULO-2334

Lacking fallback when ACCUMULO_LOG_HOST isn't set

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.0
    • Fix Version/s: 1.5.1, 1.6.0
    • Component/s: tserver
    • Labels:
      None

      Description

      For log-forwarding, if ACCUMULO_LOG_HOST is not set, the code falls back to using the hostname for localhost.

      We already have an address for the monitor in ZK; we should use that instead when populated.

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit fde149125478a294c0a04009ad6c96a7aea27675 in branch refs/heads/2334-loghost-squash from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fde1491 ]

          ACCUMULO-2334 Remove ACCUMULO_LOG_HOST in favor of pull host and port log-forwarding from zookeeper

          Advertising both the host and port for log4j gives us a couple of benefits.
          We can do away with ACCUMULO_LOG_HOST, simplify the code to always
          do the same thing (pull from zookeeper), and gain robust failover
          if the monitor is moved to a different host or is restarted with a random
          port (does not require any other service restart to become aware).

          Show
          ASF subversion and git services added a comment - Commit fde149125478a294c0a04009ad6c96a7aea27675 in branch refs/heads/2334-loghost-squash from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fde1491 ] ACCUMULO-2334 Remove ACCUMULO_LOG_HOST in favor of pull host and port log-forwarding from zookeeper Advertising both the host and port for log4j gives us a couple of benefits. We can do away with ACCUMULO_LOG_HOST, simplify the code to always do the same thing (pull from zookeeper), and gain robust failover if the monitor is moved to a different host or is restarted with a random port (does not require any other service restart to become aware).
          Hide
          Josh Elser added a comment -

          In implementing this, I came to the conclusion that it's actually a bit cleaner to just remove ACCUMULO_LOG_HOST completely and use zookeeper for monitor log-forwarding discovery.

          Made a review for the changes just to get some extra eyes on it, but I feel pretty comfortable with the changes.

          Show
          Josh Elser added a comment - In implementing this, I came to the conclusion that it's actually a bit cleaner to just remove ACCUMULO_LOG_HOST completely and use zookeeper for monitor log-forwarding discovery. Made a review for the changes just to get some extra eyes on it, but I feel pretty comfortable with the changes.
          Hide
          ASF subversion and git services added a comment -

          Commit 0351d0d416df51f0b10d91acdc074dced36e40d4 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0351d0d ]

          ACCUMULO-2334 Remove ACCUMULO_LOG_HOST in favor of pull host and port log-forwarding from zookeeper

          Advertising both the host and port for log4j gives us a couple of benefits.
          We can do away with ACCUMULO_LOG_HOST, simplify the code to always
          do the same thing (pull from zookeeper), and gain robust failover
          if the monitor is moved to a different host or is restarted with a random
          port (does not require any other service restart to become aware).

          The monitor will now acquire a zoolock before starting, which ensures that
          all tservers will perform log-forwarding to the correct monitor (in the case
          that there were multiple for some reason). Creates a better hierarchy in ZooKeeper
          for all monitor data (HTTP and Log4j advertisement). Update `accumulo init`,
          `accumulo info` and ensure that the zookeeper layout can handle an "upgrade"
          from 1.5.0.

          Show
          ASF subversion and git services added a comment - Commit 0351d0d416df51f0b10d91acdc074dced36e40d4 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0351d0d ] ACCUMULO-2334 Remove ACCUMULO_LOG_HOST in favor of pull host and port log-forwarding from zookeeper Advertising both the host and port for log4j gives us a couple of benefits. We can do away with ACCUMULO_LOG_HOST, simplify the code to always do the same thing (pull from zookeeper), and gain robust failover if the monitor is moved to a different host or is restarted with a random port (does not require any other service restart to become aware). The monitor will now acquire a zoolock before starting, which ensures that all tservers will perform log-forwarding to the correct monitor (in the case that there were multiple for some reason). Creates a better hierarchy in ZooKeeper for all monitor data (HTTP and Log4j advertisement). Update `accumulo init`, `accumulo info` and ensure that the zookeeper layout can handle an "upgrade" from 1.5.0.
          Hide
          ASF subversion and git services added a comment -

          Commit fd31595b55f66627cf6d64cb20cc874c04e9da58 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fd31595 ]

          ACCUMULO-2334 Make a slightly better ZK check for the mid-1.5.1-SNAPSHOT state.

          Show
          ASF subversion and git services added a comment - Commit fd31595b55f66627cf6d64cb20cc874c04e9da58 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fd31595 ] ACCUMULO-2334 Make a slightly better ZK check for the mid-1.5.1-SNAPSHOT state.
          Hide
          ASF subversion and git services added a comment -

          Commit fafa42961be8c6f457c5519852b398c488654980 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fafa429 ]

          ACCUMULO-2334 Use the ZooReaderWriter exists() and make a slightly better comment.

          Show
          ASF subversion and git services added a comment - Commit fafa42961be8c6f457c5519852b398c488654980 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fafa429 ] ACCUMULO-2334 Use the ZooReaderWriter exists() and make a slightly better comment.
          Hide
          ASF subversion and git services added a comment -

          Commit 0351d0d416df51f0b10d91acdc074dced36e40d4 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0351d0d ]

          ACCUMULO-2334 Remove ACCUMULO_LOG_HOST in favor of pull host and port log-forwarding from zookeeper

          Advertising both the host and port for log4j gives us a couple of benefits.
          We can do away with ACCUMULO_LOG_HOST, simplify the code to always
          do the same thing (pull from zookeeper), and gain robust failover
          if the monitor is moved to a different host or is restarted with a random
          port (does not require any other service restart to become aware).

          The monitor will now acquire a zoolock before starting, which ensures that
          all tservers will perform log-forwarding to the correct monitor (in the case
          that there were multiple for some reason). Creates a better hierarchy in ZooKeeper
          for all monitor data (HTTP and Log4j advertisement). Update `accumulo init`,
          `accumulo info` and ensure that the zookeeper layout can handle an "upgrade"
          from 1.5.0.

          Show
          ASF subversion and git services added a comment - Commit 0351d0d416df51f0b10d91acdc074dced36e40d4 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0351d0d ] ACCUMULO-2334 Remove ACCUMULO_LOG_HOST in favor of pull host and port log-forwarding from zookeeper Advertising both the host and port for log4j gives us a couple of benefits. We can do away with ACCUMULO_LOG_HOST, simplify the code to always do the same thing (pull from zookeeper), and gain robust failover if the monitor is moved to a different host or is restarted with a random port (does not require any other service restart to become aware). The monitor will now acquire a zoolock before starting, which ensures that all tservers will perform log-forwarding to the correct monitor (in the case that there were multiple for some reason). Creates a better hierarchy in ZooKeeper for all monitor data (HTTP and Log4j advertisement). Update `accumulo init`, `accumulo info` and ensure that the zookeeper layout can handle an "upgrade" from 1.5.0.
          Hide
          ASF subversion and git services added a comment -

          Commit fd31595b55f66627cf6d64cb20cc874c04e9da58 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fd31595 ]

          ACCUMULO-2334 Make a slightly better ZK check for the mid-1.5.1-SNAPSHOT state.

          Show
          ASF subversion and git services added a comment - Commit fd31595b55f66627cf6d64cb20cc874c04e9da58 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fd31595 ] ACCUMULO-2334 Make a slightly better ZK check for the mid-1.5.1-SNAPSHOT state.
          Hide
          ASF subversion and git services added a comment -

          Commit fafa42961be8c6f457c5519852b398c488654980 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fafa429 ]

          ACCUMULO-2334 Use the ZooReaderWriter exists() and make a slightly better comment.

          Show
          ASF subversion and git services added a comment - Commit fafa42961be8c6f457c5519852b398c488654980 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fafa429 ] ACCUMULO-2334 Use the ZooReaderWriter exists() and make a slightly better comment.
          Hide
          ASF subversion and git services added a comment -

          Commit fd31595b55f66627cf6d64cb20cc874c04e9da58 in branch refs/heads/master from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fd31595 ]

          ACCUMULO-2334 Make a slightly better ZK check for the mid-1.5.1-SNAPSHOT state.

          Show
          ASF subversion and git services added a comment - Commit fd31595b55f66627cf6d64cb20cc874c04e9da58 in branch refs/heads/master from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fd31595 ] ACCUMULO-2334 Make a slightly better ZK check for the mid-1.5.1-SNAPSHOT state.
          Hide
          ASF subversion and git services added a comment -

          Commit fafa42961be8c6f457c5519852b398c488654980 in branch refs/heads/master from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fafa429 ]

          ACCUMULO-2334 Use the ZooReaderWriter exists() and make a slightly better comment.

          Show
          ASF subversion and git services added a comment - Commit fafa42961be8c6f457c5519852b398c488654980 in branch refs/heads/master from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fafa429 ] ACCUMULO-2334 Use the ZooReaderWriter exists() and make a slightly better comment.
          Hide
          ASF subversion and git services added a comment -

          Commit 15bbd5393029ac2538950ce36809dd24a4b2ec32 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=15bbd53 ]

          ACCUMULO-2334 Comment in Master.upgradeZookeeper() about the checks that the monitor is also doing.

          Show
          ASF subversion and git services added a comment - Commit 15bbd5393029ac2538950ce36809dd24a4b2ec32 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=15bbd53 ] ACCUMULO-2334 Comment in Master.upgradeZookeeper() about the checks that the monitor is also doing.
          Hide
          ASF subversion and git services added a comment -

          Commit 15bbd5393029ac2538950ce36809dd24a4b2ec32 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=15bbd53 ]

          ACCUMULO-2334 Comment in Master.upgradeZookeeper() about the checks that the monitor is also doing.

          Show
          ASF subversion and git services added a comment - Commit 15bbd5393029ac2538950ce36809dd24a4b2ec32 in branch refs/heads/1.6.0-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=15bbd53 ] ACCUMULO-2334 Comment in Master.upgradeZookeeper() about the checks that the monitor is also doing.
          Hide
          ASF subversion and git services added a comment -

          Commit 15bbd5393029ac2538950ce36809dd24a4b2ec32 in branch refs/heads/master from Josh Elser
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=15bbd53 ]

          ACCUMULO-2334 Comment in Master.upgradeZookeeper() about the checks that the monitor is also doing.

          Show
          ASF subversion and git services added a comment - Commit 15bbd5393029ac2538950ce36809dd24a4b2ec32 in branch refs/heads/master from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=15bbd53 ] ACCUMULO-2334 Comment in Master.upgradeZookeeper() about the checks that the monitor is also doing.
          Hide
          ASF subversion and git services added a comment -

          Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ]

          ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch

          Fixes trivial warnings and broken javadocs which have been recently
          introduced. Specifically, removes references to private and
          package-private (default) classes in public javadoc comments (internal
          details aren't relevant to the API and subject to change). Another
          common warning was unused imports and javadoc param tags that refer to
          non-existent parameters.

          Commits against the following JIRA issues introduced these:
          ACCUMULO-1948, ACCUMULO-1974, ACCUMULO-2021, ACCUMULO-2136,
          ACCUMULO-2322, ACCUMULO-2334, ACCUMULO-2350

          Show
          ASF subversion and git services added a comment - Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ] ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch Fixes trivial warnings and broken javadocs which have been recently introduced. Specifically, removes references to private and package-private (default) classes in public javadoc comments (internal details aren't relevant to the API and subject to change). Another common warning was unused imports and javadoc param tags that refer to non-existent parameters. Commits against the following JIRA issues introduced these: ACCUMULO-1948 , ACCUMULO-1974 , ACCUMULO-2021 , ACCUMULO-2136 , ACCUMULO-2322 , ACCUMULO-2334 , ACCUMULO-2350

            People

            • Assignee:
              Josh Elser
              Reporter:
              Josh Elser
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development