Accumulo
  1. Accumulo
  2. ACCUMULO-2322

Tablet constructor leaks this, part 2

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: tserver

      Description

      Keith Turner noted during review of ACCUMULO-1948 that there is a second leaking of this in the Tablet constructor at the line:

      tabletServer.recover(this.tabletServer.getFileSystem(), this, logEntries, absPaths, new MutationReceiver() { ...
      

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 47cdb92275126ba27157dd8fefa54b30c446c3c8 in branch refs/heads/master from Bill Havanki
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=47cdb92 ]

        ACCUMULO-2322 Tablet constructor no longer leaks this to recovery process

        The method signatures for TabletServer.recover() and TabletServerLogger.recover()
        were modified so that the Tablet constructor no longer needs to pass this.

        Show
        ASF subversion and git services added a comment - Commit 47cdb92275126ba27157dd8fefa54b30c446c3c8 in branch refs/heads/master from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=47cdb92 ] ACCUMULO-2322 Tablet constructor no longer leaks this to recovery process The method signatures for TabletServer.recover() and TabletServerLogger.recover() were modified so that the Tablet constructor no longer needs to pass this.
        Hide
        Bill Havanki added a comment -

        This was a simple enough transformation that I think I can skip review. Keith Turner, you might want to peek at it just to make sure, but I reached the same conclusion you did, that only the extent and configuration were needed.

        Show
        Bill Havanki added a comment - This was a simple enough transformation that I think I can skip review. Keith Turner , you might want to peek at it just to make sure, but I reached the same conclusion you did, that only the extent and configuration were needed.
        Hide
        ASF subversion and git services added a comment -

        Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ]

        ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch

        Fixes trivial warnings and broken javadocs which have been recently
        introduced. Specifically, removes references to private and
        package-private (default) classes in public javadoc comments (internal
        details aren't relevant to the API and subject to change). Another
        common warning was unused imports and javadoc param tags that refer to
        non-existent parameters.

        Commits against the following JIRA issues introduced these:
        ACCUMULO-1948, ACCUMULO-1974, ACCUMULO-2021, ACCUMULO-2136,
        ACCUMULO-2322, ACCUMULO-2334, ACCUMULO-2350

        Show
        ASF subversion and git services added a comment - Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ] ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch Fixes trivial warnings and broken javadocs which have been recently introduced. Specifically, removes references to private and package-private (default) classes in public javadoc comments (internal details aren't relevant to the API and subject to change). Another common warning was unused imports and javadoc param tags that refer to non-existent parameters. Commits against the following JIRA issues introduced these: ACCUMULO-1948 , ACCUMULO-1974 , ACCUMULO-2021 , ACCUMULO-2136 , ACCUMULO-2322 , ACCUMULO-2334 , ACCUMULO-2350

          People

          • Assignee:
            Bill Havanki
            Reporter:
            Bill Havanki
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development